Refactor language picker to improve accessibility #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarnef
reviewed
Oct 1, 2019
| @@ -1636,5 +1636,7 @@ Mange hilsner fra Umbraco robotten | |||
| <key alias="openBackofficeSearch">Åben backoffice søgning</key> | |||
| <key alias="openCloseBackofficeHelp">Åben/Luk backoffice hjælp</key> | |||
| <key alias="openCloseBackofficeProfileOptions">Åben/Luk dine profil indstillinger</key> | |||
| <key alias="currentLanguage">Aktivt sprog:</key> | |||
| <key alias="switchLanguage">Skift sprog til:</key> | |||
There was a problem hiding this comment.
@BatJan I would probably just add the colons in the view/controller instead. It would make it easier to reuse these keys in other areas.
There was a problem hiding this comment.
Yes, good point - Done now 👍
|
Thanks @BatJan - we'll have a look soon! |
|
Awesome, thanks very much @BatJan ! |
1 task
nul800sebastiaan
added a commit
that referenced
this pull request
Oct 15, 2019
emmaburstow
pushed a commit
that referenced
this pull request
Oct 27, 2019
…ton (#6561) * Improves accessability of the three dot tree options button * Updated list view headers styling to have the link/hand cursor visible only if the header is sortable (and hence clicking has an effect) * Allows members to be ordered by additional system fields (#6575) * Fix ContentType.Alias matching in PublishedContentExtensions an… (#6577) * Fixes an error in #6538 by moving the colon character to the sr-only span * V8: Move misplaced colon in language selector (#6692) * V8: It should be possible to disallow all types at content root (#6580) * Pick macro parameters in an infinite editor like content type properties (#6586) * Reload node children after publishing with descendants * Correct URL decoding of macro partial view names (#6592) * Fix semantics for list views (#6595) * fixes test * fixing tests * Improved menu context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
In this PR I have done the following
<div>and<a>to<button>to fix keyboard navigation and semanticsaria-haspopupandaria-expandedattributesThe visual changes from before and after can be seen below
Before
After
I look forward to receive any feedback you might have for this 👍