Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/Issue - Improving accessibility of the three dot tree options button #6561

Merged
merged 15 commits into from
Oct 27, 2019
Merged

WIP/Issue - Improving accessibility of the three dot tree options button #6561

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
28882e7
Improves accessability of the three dot tree options button
Matthew-Wise Oct 2, 2019
14d0bd0
Updated list view headers styling to have the link/hand cursor visibl…
AndyButland Oct 3, 2019
28ec4da
Allows members to be ordered by additional system fields (#6575)
AndyButland Oct 15, 2019
c8c5dfe
Fix ContentType.Alias matching in PublishedContentExtensions an… (#6577)
rbottema Oct 15, 2019
4e345a8
Fixes an error in #6538 by moving the colon character to the sr-only …
nul800sebastiaan Oct 15, 2019
178185e
V8: Move misplaced colon in language selector (#6692)
Oct 15, 2019
8a85c3c
V8: It should be possible to disallow all types at content root (#6580)
Oct 15, 2019
426aa98
Pick macro parameters in an infinite editor like content type propert…
bjarnef Oct 15, 2019
8fa3ebd
Reload node children after publishing with descendants
kjac Oct 6, 2019
b8425fa
Correct URL decoding of macro partial view names (#6592)
stevemegson Oct 15, 2019
9c601ab
Fix semantics for list views (#6595)
BatJan Oct 15, 2019
72cae37
fixes test
Shazwazza Oct 16, 2019
0c5b832
fixing tests
Shazwazza Oct 16, 2019
14cea8a
Improved menu context
Matthew-Wise Oct 27, 2019
76a1ab6
Merge branch 'v8/dev' into temp-5277-22
Matthew-Wise Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Umbraco.Web.UI.Client/src/common/directives/components/tree/umbtreeitem.directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ angular.module("umbraco.directives")
},

link: function (scope, element, attrs, umbTreeCtrl) {
localizationService.localize("general_search").then(function (value) {
scope.searchAltText = value;
localizationService.localizeMany(["general_search", "visuallyHiddenTexts_openContextMenu"]).then(function (value) {
scope.searchAltText = value[0];
scope.optionsText = value[1];
});

// updates the node's DOM/styles
Expand Down
2 changes: 1 addition & 1 deletion src/Umbraco.Web.UI.Client/src/views/components/tree/umb-tree-item.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<a class="umb-tree-item__label umb-outline" ng-href="#/{{::node.routePath}}" ng-click="select(node, $event)" title="{{::node.title}}">{{node.name}}</a>

<!-- NOTE: These are the 'option' elipses -->
<button data-element="tree-item-options" class="umb-options btn-reset sr-only sr-only--focusable sr-only--hoverable" ng-click="options(node, $event)" ng-if="::node.menuUrl"><i></i><i></i><i></i></button>
<button data-element="tree-item-options" class="umb-options btn-reset sr-only sr-only--focusable sr-only--hoverable" ng-click="options(node, $event)" ng-if="::node.menuUrl" aria-label="{{optionsText}} {{node.name}}"><i></i><i></i><i></i></button>

<umb-loader ng-show="node.loading" position="bottom" class="umb-tree-item__loader"></umb-loader>
</div>
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2150,5 +2150,6 @@ To manage your website, simply open the Umbraco back office and start adding con
<key alias="openBackofficeSearch">Open backoffice search</key>
<key alias="openCloseBackofficeHelp">Open/Close backoffice help</key>
<key alias="openCloseBackofficeProfileOptions">Open/Close your profile options</key>
<key alias="openContextMenu">Open context menu for</key>
</area>
</language>
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2164,5 +2164,6 @@ To manage your website, simply open the Umbraco back office and start adding con
<key alias="openBackofficeSearch">Open backoffice search</key>
<key alias="openCloseBackofficeHelp">Open/Close backoffice help</key>
<key alias="openCloseBackofficeProfileOptions">Open/Close your profile options</key>
<key alias="openContextMenu">Open context menu for</key>
</area>
</language>