FE Release 2024-07-15 #2872
Merged
FE Release 2024-07-15 #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Trajan0x <[email protected]>
* design updates to the explorer * adding custom svg * Adjust icon sizing * Align tx rows * Scale Tx table down to mobile * Arrow appears on hover * Align mobile buttons --------- Co-authored-by: bigboydiamonds <[email protected]>
- @synapsecns/[email protected]
Fix screener HTTP responses
Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: Trajan0x <[email protected]>
* WIP:ctrl+c handling + test for commandline * removing faulty tests from PR
Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: Trajan0x <[email protected]>
address #2823, #2822, #2820 and #2819 --------- Co-authored-by: Trajan0x <[email protected]>
* improve submitter docs * add a big comment * account for random map iteration * relayer submitter bump --------- Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: Trajan0x <[email protected]>
- **New Features** - Introduced a new 'Keys()' method in map mutex interfaces for retrieving all keys. - Added logging for state transitions in quote requests. - **Bug Fixes** - Enhanced the `UpdateQuoteRequestStatus` function to check for valid state transitions and log any invalid transitions. - **Tests** - Added new test cases for key retrieval in different types of map mutexes. --------- Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: Trajan0x <[email protected]> Co-authored-by: vro <[email protected]>
* Increase default buffer * Fix
- @synapsecns/[email protected]
Bumps [services/cctp-relayer/external/evm-cctp-contracts](https://github.com/circlefin/evm-cctp-contracts) from `817397d` to `377c9bd`. - [Release notes](https://github.com/circlefin/evm-cctp-contracts/releases) - [Commits](circlefin/evm-cctp-contracts@817397d...377c9bd) --- updated-dependencies: - dependency-name: services/cctp-relayer/external/evm-cctp-contracts dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------- Co-authored-by: Trajan0x <[email protected]>
- @synapsecns/[email protected] - [email protected] - @synapsecns/[email protected] - @synapsecns/[email protected] - @synapsecns/[email protected] - @synapsecns/[email protected] - [email protected] - @synapsecns/[email protected] - @synapsecns/[email protected]
Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: Trajan0x <[email protected]>
- @synapsecns/[email protected]
* Adds destination address middleware screening check * Changes screenAddress to async/await * Moves bl check into screenAddress
- @synapsecns/[email protected]
abtestingalpha
requested review from
trajan0x,
dwasse,
aureliusbtc,
bigboydiamonds,
Defi-Moses and
ChiTimesChi
as code owners
github-actions
bot
added
M-ci
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 163 files out of 220 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine-fe with
|
| Latest commit: |
73863ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e8d0b78.sanguine-fe.pages.dev |
| Branch Preview URL: | https://master.sanguine-fe.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added 'carryforward: true' to 'cctp-relayer' in
.codecov.yml - Skipped 'otelginmetrics' directory in
.golangci.yml - Introduced new
rfqRefundcommand incontrib/opbot/botmd/commands.go - Added tracing and metrics middleware in
contrib/opbot/botmd/middleware.go - Updated dependencies and configurations in
contrib/opbot/go.modandcontrib/opbot/config/config.go
15 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+75
to
+77
| otr.activeRequestsCounter, err = meter.Int64UpDownCounter("slacker.active_requests") | ||
| if err != nil { | ||
| log.Warnf("failed to create histogram: %v", err) |
There was a problem hiding this comment.
Style: The log message should specify that the creation of the active requests counter failed.
Comment on lines
+18
to
+20
| func NewStore(db *gorm.DB, metrics metrics.Handler) *Store { | ||
| txDB := txdb.NewTXStore(db, metrics) | ||
| return &Store{db: db, metrics: metrics, submitterStore: txDB} |
There was a problem hiding this comment.
Style: Consider adding error handling for the creation of txDB to manage potential initialization failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
4091384: docs preview link
4091384: synapse-interface preview link
4091384: explorer-ui preview link