change to latest block number for default value in listener

[golangisfun123]

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

• Fixes #[Link to Issue]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of unrecognized finality modes, now defaulting to the latest block number instead of a safe block number.

[coderabbitai]

Walkthrough

The WithFinalityMode function in the ethergo package has been updated to set the finalityMode to rpc.LatestBlockNumber instead of rpc.SafeBlockNumber when an unrecognized mode is provided. This change ensures that the latest block is considered by default in cases of invalid input.

Changes

File	Change Summary
ethergo/listener/options.go	WithFinalityMode now defaults finalityMode to rpc.LatestBlockNumber when given an unrecognized mode.

Poem

When modes go astray, and options seem gray,
Default to the latest, and block no delay.
A tweak in the code, for paths we decode,
Ensures that the newest is always bestowed.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

PR Summary

• Changed default finality mode to LatestBlockNumber in /ethergo/listener/options.go
• Review impact on block confirmation reliability and safety

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[cloudflare-workers-and-pages]

Deploying sanguine-fe with    Cloudflare Pages

Latest commit:	7c24e50
Status:	✅  Deploy successful!
Preview URL:	https://f8eb53b6.sanguine-fe.pages.dev
Branch Preview URL:	https://not-executing.sanguine-fe.pages.dev

View logs

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8b83ad8 and 7c24e50.

Files selected for processing (1)

• ethergo/listener/options.go (1 hunks)

Additional comments not posted (1)

ethergo/listener/options.go (1)

42-42: LGTM! Verify the impact of defaulting to rpc.LatestBlockNumber.

The change defaults the finality mode to rpc.LatestBlockNumber for unrecognized modes. Ensure that this does not adversely affect the system's consistency and finality guarantees.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@8b83ad8). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files	Patch %	Lines
ethergo/listener/options.go	0.00000%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master       #2869   +/-   ##
============================================
  Coverage          ?   21.95880%           
============================================
  Files             ?         640           
  Lines             ?       50868           
  Branches          ?           0           
============================================
  Hits              ?       11170           
  Misses            ?       38380           
  Partials          ?        1318           

Flag	Coverage Δ
agents	34.20858% <ø> (?)
cctp-relayer	31.97848% <ø> (?)
ethergo	48.09957% <0.00000%> (?)
explorer	4.97877% <ø> (?)
omnirpc	33.23904% <ø> (?)
opbot	0.18564% <ø> (?)
promexporter	8.50242% <ø> (?)
rfq	24.76775% <ø> (?)
scribe	18.17597% <ø> (?)
tools	30.55118% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.