(nit:core) Standardize semconv version #2812
Conversation
WalkthroughThe recent updates focus on upgrading the version of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Update OpenTelemetry semantic conventions version to v1.25.0
- Replace
HTTPServerNameKeywithServiceNameKey - Modify HTTP status code recording to use
HTTPResponseStatusCodeKey
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Deploying sanguine-fe with
|
| Latest commit: |
50b6e68
|
| Status: | 🚫 Build failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
===================================================
+ Coverage 25.52169% 25.54179% +0.02009%
===================================================
Files 765 765
Lines 54726 54726
Branches 80 80
===================================================
+ Hits 13967 13978 +11
+ Misses 39316 39310 -6
+ Partials 1443 1438 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- core/metrics/instrumentation/otelginmetrics/config.go (2 hunks)
- core/metrics/instrumentation/otelginmetrics/middleware.go (2 hunks)
Additional comments not posted (4)
core/metrics/instrumentation/otelginmetrics/config.go (2)
7-7: Updated import path for semconv package.The import path has been updated to reflect the new semantic conventions version
v1.25.0. This change is consistent with the PR's objective to standardize the semconv version across the project.
39-39: Verify the attribute key change inDefaultAttributes.The attribute key has been changed from
HTTPServerNameKeytoServiceNameKey. Ensure this change aligns with the updated semantic conventions inv1.25.0of the semconv package.core/metrics/instrumentation/otelginmetrics/middleware.go (2)
8-8: Updated import path for semconv package.The import path has been updated to the new version
v1.25.0, aligning with the PR's goal of standardizing the semconv version.
52-52: Verify the method change inMiddleware.The method
HTTPAttributesFromHTTPStatusCodehas been replaced withHTTPResponseStatusCodeKey.Int. Ensure this change is appropriate and aligns with the updated semantic conventions inv1.25.0of the semconv package.
Description
Summary by CodeRabbit