Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vue stuff #2032

Merged
merged 29 commits into from
Oct 16, 2017
Merged

Update vue stuff #2032

merged 29 commits into from
Oct 16, 2017

Conversation

dependencies[bot]
Copy link

@dependencies dependencies bot commented Oct 13, 2017

vue has been updated to 2.5.1 in app/vue by dependencies.io

2.5.1

Bug Fixes

2.5.0

Features & Improvements

Error Handling and Reporting

TypeScript Declaration Improvements

Functional Components

  • compiled templates for functional component support ea0d227

  • scoped CSS support for functional components 050bb33

    These features require vue-loader>=13.3.0. Thanks to the work by blake-newman. [Details]

Server Side Rendering

v-model

v-on

Scoped Slots

  • support denoting normal elements as scoped slot dae173d [Details]

Provide/Inject

<keep-alive>

  • add max prop for <keep-alive> for limiting max number of instances cached 2cba6d4

Other Improvements

Bug Fixes

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #2032 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2032   +/-   ##
=======================================
  Coverage   21.34%   21.34%           
=======================================
  Files         262      262           
  Lines        5767     5767           
  Branches      689      694    +5     
=======================================
  Hits         1231     1231           
+ Misses       4031     4018   -13     
- Partials      505      518   +13
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 20% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.97% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6a678...16054b5. Read the comment docs.

…app--vue' into vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	app/vue/package.json
…examples--vue-kitchen-sink' into vue-2.5.1-23.0.0-app--vue
….0-examples--vue-kitchen-sink' into vue-2.5.1-23.0.0-app--vue
…kitchen-sink' into vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	examples/vue-kitchen-sink/package.json
#	yarn.lock
@Hypnosphi Hypnosphi changed the title Update vue from 2.4.4 to 2.5.1 in app/vue Update vue stuff Oct 13, 2017
@Hypnosphi Hypnosphi requested a review from a team October 13, 2017 18:48
@Hypnosphi
Copy link
Member

vue-kitchen-sink seems to work OK, but I think I need another pair of eyes

…into vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	addons/knobs/package.json
#	yarn.lock
…vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	app/vue/package.json
#	yarn.lock
…itchen-sink' into vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	examples/vue-kitchen-sink/package.json
#	yarn.lock
Hypnosphi and others added 5 commits October 15, 2017 01:52
….0-app--vue' into vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	app/vue/package.json
….0-examples--vue-kitchen-sink' into vue-2.5.1-23.0.0-app--vue

# Conflicts:
#	examples/vue-kitchen-sink/package.json
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No majors were bumped, if kitchen sink works, I think we can go ahead.

@Hypnosphi Hypnosphi merged commit 59e947a into master Oct 16, 2017
@Hypnosphi Hypnosphi deleted the vue-2.5.1-23.0.0-app--vue branch October 16, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants