Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar supports theming again #6794

Merged
merged 2 commits into from
May 16, 2019
Merged

Scrollbar supports theming again #6794

merged 2 commits into from
May 16, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented May 16, 2019 •
edited by shilman
Loading

Issue: #6753

Core issue is #6753. @ndelangen's #6785 reimplements simplebar styles. This PR adds theming support back in.

What I did

Add theming support back in

How to test

  • Change to dark theme and see white scroll bar
  • Change to light theme and see dark scroll bar

Screen Recording 2019-05-16 at 09 21 AM
Screen Recording 2019-05-16 at 09 20 AM

@domyen domyen requested a review from ndelangen May 16, 2019 01:23
@domyen domyen requested a review from tmeasday as a code owner May 16, 2019 01:23
@vercel
Copy link

vercel bot commented May 16, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-6753-scrollbar-support-theming.storybook.now.sh

@domyen domyen mentioned this pull request May 16, 2019
Closed
@shilman shilman added this to the 5.1.0 milestone May 16, 2019
shilman
shilman approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domyen we should probably fix theming so we don't need to hardcode it like this. Merging for now so I can release.

@shilman shilman merged commit 864de9b into next May 16, 2019
@shilman shilman deleted the 6753-scrollbar-support-theming branch May 16, 2019 04:07
This was referenced Jan 15, 2021
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

@CodeByAlex CodeByAlex Awaiting requested review from CodeByAlex

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

Assignees
No one assigned
Labels
bug theming ui
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@domyen @shilman