Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first knobs button with a title that contains brackets does not render. #6790

Closed
jung-han opened this issue May 15, 2019 · 3 comments
Closed

Comments

@jung-han
Copy link
Contributor

Describe the bug
Hi, I am currently using a storybook using the knobs button in ^5.1.0-alpha.40 version.

I found a bug ...
The first knobs button with a title that contains brackets does not render.
However, if the first button is exposed, it will render normally.

Expected behavior
The text must be fully exposed, no matter what text is entered.

Code snippets

// not work
button('selection({ start: [1, 2], end: [3, 4] })', () =>
  app.selection({ start: [1, 2], end: [3, 4] })
);

// work
button('test', () => console.log('test'));
button('selection({ start: [1, 2], end: [3, 4] })', () =>
  app.selection({ start: [1, 2], end: [3, 4] })
);

Screenshots

// first Code snippets code
image

// second Code snippets code
image

System:

  • OS: OSX
  • Device: macbook pro 2018
  • Browser: chrome
  • Framework: preact
  • Addons: ^5.1.0-alpha.40
  • Version: ^5.1.0-alpha.40

Additional context
Thanks!

@leoyli
Copy link
Contributor

leoyli commented May 23, 2019

related #6526.

@shilman shilman modified the milestones: 5.1.0, 5.1.x Jun 5, 2019
@stale
Copy link

stale bot commented Jun 26, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 26, 2019
@stale
Copy link

stale bot commented Jul 26, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants