Fix angular project without 'architect.build' option to be worked #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess it should be developers instead of users.
updated docs to reflect proper params passed to webpack.config.js
A copy change
updated docs to reflect proper params passed to webpack.config.js
The doc says `export default create({...` for the theme
Theme docs fix
Bump version number in live examples page
Fix broken link to badge svg
Fix typo in example, use MyPanel component
Readme updated to reference jsDelivr for the badge
Updated list of peerDependencies for mithriljs.
Docs: Typescript Configuration Examples for v5
…g-before-searching lib client-api/src/client_api: check type of module.id as fileName
…debouncing [Addon: Knobs] - Performance Fix: added debouncing between keystrokes to speed up component rendering
Fixed missing iframe.html in output directory
Add core JS dependencies across the stack where it was missing
Core: support unicode chars in story IDs
Remove custom presets warning
add missing `addDecorator` import
improve the docs for V5 launch
Fix example of setting defaultViewport per story
seokju-na
requested review from
alterx,
CodeByAlex,
dangreenisrael,
danielduan,
Gongreg,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
naipath,
ndelangen,
renaudtertrais,
rmevans9,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
This was referenced Jan 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6735
What I did
Since 'architect.build' options are not essential, this PR allows angular projects which has no 'architect.build' options.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.