Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A copy change #5920

Merged
merged 1 commit into from
Mar 7, 2019
Merged

A copy change #5920

merged 1 commit into from
Mar 7, 2019

Conversation

gulshankumardev
Copy link

I guess it should be developers instead of users.

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@gulshankumardev
A copy change
18713e2 
I guess it should be developers instead of users.
@codecov
Copy link

codecov bot commented Mar 6, 2019 •
edited
Loading

Codecov Report

Merging #5920 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5920   +/-   ##
=======================================
  Coverage   34.38%   34.38%           
=======================================
  Files         636      636           
  Lines        9374     9374           
  Branches     1348     1323   -25     
=======================================
  Hits         3223     3223           
  Misses       5508     5508           
  Partials      643      643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8998c58...18713e2. Read the comment docs.

shilman
shilman approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 👌

@shilman shilman added documentation cleanup Minor cleanup style change that won't show up in release changelog patch:yes Bugfix & documentation PR that need to be picked to main branch and removed documentation labels Mar 6, 2019
@shilman shilman merged commit 378a8b5 into storybookjs:master Mar 7, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 7, 2019
shilman added a commit that referenced this pull request Mar 7, 2019
@shilman
Merge pull request #5920 from designergulshan/patch-3
7a74d8d 
A copy change
@gulshankumardev gulshankumardev deleted the patch-3 branch March 8, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

Assignees
No one assigned
Labels
cleanup Minor cleanup style change that won't show up in release changelog patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulshankumardev @shilman