Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.6 #1166

Merged
merged 1 commit into from
Oct 4, 2023
Merged

2023.6 #1166

merged 1 commit into from
Oct 4, 2023

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Aug 22, 2023

ska3-matlab 2023.6

This PR includes:

  • Changes in proseco and sparkles to make ACA penalty limit optional
  • A fix to ska_helpers so it won't modify the git index in the chandra_models repo -- this was causing fot tools SVN to warn/complain
  • Some improvements to the testr module to make it possible to run Python unit tests from Matlab / pyexec
  • Small updates to improve chandra_models access, including a change to xija so it will use ska_helpers.chandra_models -- the consequence of this is that xija thermal model access will respect the CHANDRA_MODELS_DIR and CHANDRA_MODELS_DEFAULT_VERSION environment variables.

Interface Impacts:

Testing:

The latest release candidates will be installed in /proj/sot/ska3/matlab/test on GRETA,
and all release candidates will be available for testing from the usual channels:

conda create -n ska3-matlab-2023.6rc1 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-matlab==2023.6rc1

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-matlab 2023.6 will be promoted to flight conda channel and installed on GRETA Linux after approval from FOT team.

Code changes

ska3-matlab changes (2023.5 -> 2023.6rc1)

Updated Packages

  • fot-matlab: 2.2.0 -> 2.3.0 (2.2.0 -> 2.3.0)
    • PR 21 (James Kristoff): MATLAB-12004 - parallelize star acquisition
    • PR 22 (James Kristoff): parallelized aca results
    • PR 23 (James Kristoff): fixing call args for single catalog acq path.
    • PR 24 (James Kristoff): MATLAB-12001 - SIM position states and plot do not agree with each other
  • kadi: 7.4.1 -> 7.5.0 (7.4.1 -> 7.5.0)
    • PR 292 (Tom Aldcroft): Add validator for sun position monitor
  • parse_cm: 3.10.0 -> 3.11.0 (3.10.0 -> 3.11.0)
    • PR 41 (John ZuHone): Only use local paths for fetching the ACIS tables
  • proseco: 5.9.0 -> 5.10.0 (5.9.0 -> 5.10.0)
    • PR 384 (Tom Aldcroft): Make ACA penalty limit optional
    • PR 385 (Tom Aldcroft): Add test of optional ACA limits
    • PR 386 (Tom Aldcroft): Improve implementation of characteristics from ACA xija model
  • ska3-core: 2023.1 -> 2023.3
  • ska_helpers: 0.10.3 -> 0.11.0 (0.10.3 -> 0.10.4 -> 0.11.0)
    • PR 42 (Jean Connelly): Replace git_helpers subprocess with gitpython and revert #41
    • PR 46 (Jean Connelly): Remove extra repo from git config command
    • PR 45 (Jean Connelly): Skip git safe test on old git
    • PR 48 (Jean Connelly): Skip is_dirty check from matlab tools
  • ska_sync: 4.10.1 -> 4.11.0 (4.10.1 -> 4.11.0)
    • PR 32 (John ZuHone): Sync ACIS tables
  • sparkles: 4.22.2 -> 4.23.0 (4.22.2 -> 4.23.0)
    • PR 195 (Jean Connelly): Update to use more test fixtures
    • PR 193 (Jean Connelly): With dyn_bgd_n_faint option, override it in the GuideTable too
    • PR 196 (Jean Connelly): Do not use aca_t_ccd_penalty_limit via import
  • starcheck: 14.1.0 -> 14.3.0 (14.1.0 -> 14.2.1 -> 14.3.0)
    • PR 411 (Jean Connelly): Set plot ymin relative to planning not penalty limit
    • PR 420 (Jean Connelly): Downgrade bad guide data warning
    • PR 423 (Jean Connelly): Handle vehicle mode with custom filtered backstop (was PR 421)
    • PR 429 (Jean Connelly): Work with optional penalty limit in model spec
    • PR 425 (Jean Connelly): Planning t_ccd critical warning
  • testr: 4.11.3 -> 4.12.0 (4.11.3 -> 4.12.0)
    • PR 50 (Jean Connelly): Add handling for missing isatty attr on stdout
    • PR 51 (Jean Connelly): Handle StdOutWrapper class with context manager
  • xija: 4.30.0 -> 4.31.0 (4.30.0 -> 4.31.0)
    • PR 134 (Tom Aldcroft): Refactor get_model_spec to use ska_helpers.chandra_models

Related Issues

Fixes #1155
Fixes #1157
Fixes #1158
Fixes #1159
Fixes #1160
Fixes #1161
Fixes #1162
Fixes #1163
Fixes #1164
Fixes #1165
Fixes #1167
Fixes #1169

@javierggt javierggt merged commit ac166f3 into master Oct 4, 2023
7 checks passed
@javierggt javierggt deleted the 2023.6-branch branch November 20, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant