Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade bad guide data warning #420

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Downgrade bad guide data warning #420

merged 1 commit into from
Jul 19, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jul 13, 2023

Description

Downgrade bad guide star critical warning

Fixes #410

Interface impacts

Testing

Unit tests

  • Linux

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

I ran this and the most recent starcheck release (14.1.0) on JUN0523A in

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr420

Relevant output is just the diff that shows that this change downgrades two Bad Guide Star warnings from CRITICAL to WARNING status.

1,2c1,2
<  ------------  Starcheck 14.1.0    -----------------
<  Run on Thu Jul 13 15:26:56 EDT 2023 by jeanconn from fido.cfa.harvard.edu
---
>  ------------  Starcheck 14.1.1.dev1+g3c6fd09    -----------------
>  Run on Thu Jul 13 15:22:08 EDT 2023 by jeanconn from fido.cfa.harvard.edu
89c89
< OBSID = 25715 at 2023:158:16:07:59.994   6.3 ACQ | 4.8 GUI | Critical: 1 Warn: 1 Caution: 9
---
> OBSID = 25715 at 2023:158:16:07:59.994   6.3 ACQ | 4.8 GUI | Warn: 2 Caution: 9
91c91
< OBSID = 25729 at 2023:159:07:44:05.688   6.0 ACQ | 4.8 GUI | Critical: 1 Caution:13
---
> OBSID = 25729 at 2023:159:07:44:05.688   6.0 ACQ | 4.8 GUI | Warn: 1 Caution:13
1436c1436
< >> CRITICAL: [ 6] Bad Guide Star. 1052122960 has bad data  1 of  3 attempts
---
> >> WARNING : [ 6] Bad Guide Star. 1052122960 has bad data  1 of  3 attempts
1515c1515
< >> CRITICAL: [ 7] Bad Guide Star. 1052122960 has bad data  1 of  3 attempts
---
> >> WARNING : [ 7] Bad Guide Star. 1052122960 has bad data  1 of  3 attempts

@jeanconn jeanconn requested review from javierggt and taldcroft July 19, 2023 15:39
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeanconn jeanconn merged commit 080bf2e into master Jul 19, 2023
@jeanconn jeanconn deleted the bad-guide-not-critical branch July 19, 2023 16:29
@jeanconn jeanconn mentioned this pull request Aug 18, 2023
2 tasks
@javierggt javierggt mentioned this pull request Sep 6, 2023
@javierggt javierggt mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade bad guide star critical warning
2 participants