Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning t_ccd critical warning #425

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Planning t_ccd critical warning #425

merged 2 commits into from
Aug 19, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Aug 7, 2023

Description

Change the "over the planning limit" warning to critical/red .

Interface impacts

Testing

Unit tests

  • Linux

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr428/

/proj/sot/ska3/flight/bin/skare starcheck -dir /data/mpcrit1/mplogs/2023/JUL3123/oflsa -out jul3123a_flight
/proj/sot/ska3/flight/bin/skare /home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUL3123/oflsa -out jul3123a_test
diff -u jul3123a_flight.txt jul3123a_test.txt > diff.txt

The diffs also show the change due to #420 as the diffs are against flight not master starcheck output, which is acceptable in this case.

@jeanconn jeanconn changed the title WIP: Planning t_ccd critical warning Planning t_ccd critical warning Aug 18, 2023
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the comment above should be adjusted as well.

@jeanconn jeanconn merged commit 6893377 into master Aug 19, 2023
@jeanconn jeanconn deleted the planning-critical branch August 19, 2023 13:38
@javierggt javierggt mentioned this pull request Sep 6, 2023
@javierggt javierggt mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants