Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use more test fixtures #195

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Update to use more test fixtures #195

merged 6 commits into from
Jul 26, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jul 24, 2023

Description

Update to use more test fixtures. This moves the agasc supplement disable to conftest.py and makes the shared data in test_find_er_catalog use fixtures that also respect the CHANDRA_MODELS_DEFAULT_VERSION pinned in conftest.py.

This finishes #190 . Without the changes to test_find_er_catalog, the ska_testr sparkles test will continue to include a UserWarning that is difficult to filter that the acquisition model is correctly clipped out of the temperature range.

============================================================ warnings summary ============================================================
../../../../ska3/test/lib/python3.10/site-packages/chandra_aca/star_probs.py:390
  /proj/sot/ska3/test/lib/python3.10/site-packages/chandra_aca/star_probs.py:390: UserWarning: 
  Model grid-local-quadratic-2023-05.fits.gz computed between 5.0 <= mag <= 10.75, clipping input mag(s) outside that range.
    warnings.warn(

Interface impacts

Testing

Unit tests

  • Linux

Independent check of unit tests by @taldcroft

  • Mac (ran tests in this branch and saw no warnings)

Functional tests

No functional testing.

@jeanconn jeanconn requested review from taldcroft and javierggt July 24, 2023 17:28
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks reasonable to me.

@jeanconn jeanconn merged commit 9a926e8 into master Jul 26, 2023
@jeanconn jeanconn deleted the catch-clip branch July 26, 2023 17:31
@javierggt javierggt mentioned this pull request Sep 6, 2023
@javierggt javierggt mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants