Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to use more test fixtures. This moves the agasc supplement disable to conftest.py and makes the shared data in test_find_er_catalog use fixtures that also respect the CHANDRA_MODELS_DEFAULT_VERSION pinned in conftest.py.
This finishes #190 . Without the changes to test_find_er_catalog, the ska_testr sparkles test will continue to include a UserWarning that is difficult to filter that the acquisition model is correctly clipped out of the temperature range.
Interface impacts
Testing
Unit tests
Independent check of unit tests by @taldcroft
Functional tests
No functional testing.