Refactor get_model_spec to use ska_helpers.chandra_models #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I note that removal of the repo-tip check (already removed in ska_helpers) could count as an interface / api change (or at least a behavior change -- in the right direction). |
jeanconn
approved these changes
Aug 13, 2023
This was referenced Aug 22, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the
get_model_specmodule to useska_helpers.chandra_models.Interface impacts
None, this is expected to be API compatible with the previous version.
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.