[Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/he action destination
|
@joe-ayoub-segment Please review this PR and it would be great if it can be merged soon. Also, no segmenter is actively using this integration right now, so there shouldn't be any breaking changes. Thank you |
|
hey @joe-ayoub-segment Is it possible to get this deployed in tomorrow's release we are waiting on this fix to onboard some customers. Thank you |
|
hi @zhadier39 and @saadhypng, thanks for raising this PR. I'll schedule for review. |
joe-ayoub-segment
requested changes
Nov 22, 2023
| @@ -0,0 +1,48 @@ | |||
| // Generated file. DO NOT MODIFY IT BY HAND. | |||
|
|
|||
There was a problem hiding this comment.
Hi @zhadier39 and @saadhypng the PR looks good. Can you just remove the change to this file from the PR please?
It was likely automatically added when you ran the ./bin/run generate:types command.
Next steps are:
- We're planning a deploy next Wednesday. The deploy rolls out across 2 days, so the code will be live for all customers by the end of Thursday.
There was a problem hiding this comment.
@zhadier39 Will get this updated.
Also @joe-ayoub-segment On the deployment we will convert to our customers to install on next Thursday.
Thanks
There was a problem hiding this comment.
Thanks @zhadier39 and @saadhypng .
Just to clarify: We don't have a deploy happening this week. If we did we would push this change out.
The next deploy is next Wednesday/Thursday.
Best regards,
Joe
There was a problem hiding this comment.
Yes got it, next Thursday it will be live. 30th November.
…es/audienceEnteredSFTP.types.ts Remove auto generated types file on liveramp platform
joe-ayoub-segment
approved these changes
Nov 22, 2023
|
Hi @zhadier39 and @saadhypng , Looks like some CI issues. Can you take a look please?
Thanks |
|
@joe-ayoub-segment I think the issue is resolved now. |
Thank you @saadhypng , looks good! I'll merge prior to deploy. |
Munter
added a commit
to bucketco/segment-action-destinations
that referenced
this pull request
Nov 29, 2023
…nation * segment/main: (59 commits) Publish attempting to fix breaking buildkite CI registering 1flow and jimo web Integrations Publish create trackEvent and identifyUser browser-destinations for 1flow (segmentio#1703) fix(Jimo): resolve when jimo is not an array & remove manualInit from settings (segmentio#1740) fix for empty string in setting (segmentio#1734) Yahoo audiences 5 (segmentio#1742) [STRATCONN] Klaviyo AddToProfileList and RemoveFromProfileList actions with engage setup (segmentio#1723) Add updateHandler to Actions DV360 (segmentio#1726) Inc-7055 long term fix: add external ids to message tags (segmentio#1744) Channels-973: parse text field of action buttons (segmentio#1738) LR: Fix CSV generator to account for all rows (segmentio#1735) [STRATCONN-3376] Add phone number to TikTok Audiences (segmentio#1730) rename full_name to display_name to fix API changes (segmentio#1743) adding default paths for click id and cookie (segmentio#1729) [Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call (segmentio#1733) adding updated generated types for moengage Added key value pair of new regional endpoint (segmentio#1727) v3.89.0 (segmentio#1725) ...
|
Hi @zhadier39 and @saadhypng this PR has been deployed. |
marinhero
pushed a commit
that referenced
this pull request
Nov 30, 2023
…ser_id field in group call (#1733) * Add unit and integration tests * Updated field descriptions for group, identify and track * Updated common fields * Fix identify function error * Added authentication endpoint * Revise tests to enable auth * Update default paths for groupId. * Implement recommended changes from PR #1621 * Add url field * Resolve pathing issues and add tests/checks for first and last name fields * Resolve test issues, payload validation error, and correct context default * Fix no user_id field in group call and timezone offset bug * Add tests for new functionality * Delete packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSFTP.types.ts Remove auto generated types file on liveramp platform * Fix ts error with timeZoneName --------- Co-authored-by: saadhypng <[email protected]> Co-authored-by: Saad Ali <[email protected]>
harsh-joshi99
added a commit
that referenced
this pull request
Dec 6, 2023
commit 12d62f7 Author: Harsh Joshi <[email protected]> Date: Wed Dec 6 10:29:30 2023 +0530 cleanup commit 3b8b9ed Author: Harsh Joshi <[email protected]> Date: Mon Dec 4 10:36:54 2023 +0530 Code changes and unit tests commit 2edb75e Merge: 8e9e776 ad48899 Author: Harsh Joshi <[email protected]> Date: Wed Nov 29 18:01:45 2023 +0530 Merge branch 'STRATCONN-3399' into klaviyo-add-to-profile-batch commit 8e9e776 Author: Elena <[email protected]> Date: Wed Nov 29 04:02:37 2023 -0800 Yahoo audiences 5 (#1742) * new audience settings, logging * mapping change, device type commit 7b0fe44 Author: Ankit Gupta <[email protected]> Date: Wed Nov 29 17:25:49 2023 +0530 [STRATCONN] Klaviyo AddToProfileList and RemoveFromProfileList actions with engage setup (#1723) * AddToProfileList and RemoveFromProfileList action added * added new flow of addProfileToList and RemoveProfileFromList actions in klaviyo * completed audience setup for klaviyo * updated api key field for klaviyo * change in remove from list api test cases * full audience sync turned off for audience klaviyo * changing default path of external_id * Removed debug codes * code refactored * change in addProfile and removeProfile in klaviyo * Resolved build error * Resolved build error * Added buildHeaders function * Seperated addProfile and RemoveProfile Functions * Added audience desctiption * Change error handling of createProfile function * Change error handling of createProfile function * Modified in addProfileToList Test case commit 6db1308 Author: Marín Alcaraz <[email protected]> Date: Wed Nov 29 03:54:19 2023 -0800 Add updateHandler to Actions DV360 (#1726) * Add updateHandler to Actions DV360 * Fix tests * update yarn.lock commit ac78bc7 Author: alfrimpong <[email protected]> Date: Wed Nov 29 05:50:15 2023 -0600 Inc-7055 long term fix: add external ids to message tags (#1744) * feat: add external id type & value to message tags * feat: add test to enforce passthrough commit 31e207c Author: alfrimpong <[email protected]> Date: Wed Nov 29 05:44:38 2023 -0600 Channels-973: parse text field of action buttons (#1738) * feat: parse merge tags in action button text * chore: added unit test commit 593b024 Author: Sayan Das <[email protected]> Date: Wed Nov 29 17:14:02 2023 +0530 LR: Fix CSV generator to account for all rows (#1735) * Fixed CSV generator to account for all rows * Updated CSV processor, tests and snapshots commit ce3c082 Author: maryamsharif <[email protected]> Date: Wed Nov 29 03:43:21 2023 -0800 [STRATCONN-3376] Add phone number to TikTok Audiences (#1730) * Add phone number * Fix unit tests * Hide enable batching field + adjust names commit 6fc66be Author: Chris Brown <[email protected]> Date: Wed Nov 29 06:42:32 2023 -0500 rename full_name to display_name to fix API changes (#1743) * rename full_name to display_name to fix API changes * Update full_name to display_name in tests commit 10cc239 Author: Joe Ayoub <[email protected]> Date: Wed Nov 29 12:42:06 2023 +0100 adding default paths for click id and cookie (#1729) commit 5d80f5e Author: zhadier39 <[email protected]> Date: Wed Nov 29 16:41:16 2023 +0500 [Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call (#1733) * Add unit and integration tests * Updated field descriptions for group, identify and track * Updated common fields * Fix identify function error * Added authentication endpoint * Revise tests to enable auth * Update default paths for groupId. * Implement recommended changes from PR #1621 * Add url field * Resolve pathing issues and add tests/checks for first and last name fields * Resolve test issues, payload validation error, and correct context default * Fix no user_id field in group call and timezone offset bug * Add tests for new functionality * Delete packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSFTP.types.ts Remove auto generated types file on liveramp platform * Fix ts error with timeZoneName --------- Co-authored-by: saadhypng <[email protected]> Co-authored-by: Saad Ali <[email protected]> commit ad48899 Author: Harsh Joshi <[email protected]> Date: Wed Nov 29 15:54:05 2023 +0530 Update error handling commit e9f2370 Author: Harsh Joshi <[email protected]> Date: Fri Nov 24 11:42:37 2023 +0530 Add enable batching commit a75cedd Author: Harsh Joshi <[email protected]> Date: Fri Nov 24 11:06:45 2023 +0530 Add performBatch in upsert profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has no breaking changes. In this PR, we updated fallback mappings for created at and plan fields, fixed function that returned local timezone offset and added user_id field in group events. @saadhypng
Release in the upcoming deployment would be great. Thanks!
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.