-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Jimo): resolve when jimo is not an array & remove manualInit from settings #1740
Conversation
Hi @imsamdez , Was the manualInit setting referenced anywhere in the code base? Have all references to it been removed? Best regards. |
Now, yes 😅 Best, |
…nation * segment/main: (59 commits) Publish attempting to fix breaking buildkite CI registering 1flow and jimo web Integrations Publish create trackEvent and identifyUser browser-destinations for 1flow (segmentio#1703) fix(Jimo): resolve when jimo is not an array & remove manualInit from settings (segmentio#1740) fix for empty string in setting (segmentio#1734) Yahoo audiences 5 (segmentio#1742) [STRATCONN] Klaviyo AddToProfileList and RemoveFromProfileList actions with engage setup (segmentio#1723) Add updateHandler to Actions DV360 (segmentio#1726) Inc-7055 long term fix: add external ids to message tags (segmentio#1744) Channels-973: parse text field of action buttons (segmentio#1738) LR: Fix CSV generator to account for all rows (segmentio#1735) [STRATCONN-3376] Add phone number to TikTok Audiences (segmentio#1730) rename full_name to display_name to fix API changes (segmentio#1743) adding default paths for click id and cookie (segmentio#1729) [Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call (segmentio#1733) adding updated generated types for moengage Added key value pair of new regional endpoint (segmentio#1727) v3.89.0 (segmentio#1725) ...
… settings (#1740) * feat(sendUserData): handle traits * chore(clean): remove console.log * chore(eslint): remove warning * fix(Jimo): resolve when jimo is not an array & remove manualInit from settings * fix(Jimo): remove all ref to manualInit
Hi @imsamdez , Apologies for the late notice, but we had to roll back this week's Web deploy due to an issue with some code which resulted in an incident. It was unrelated to this PR, however we needed to roll back everything. We plan to deploy the code again across Monday/Tuesday next week. Apologies again for the inconvenience. |
Hey @joe-ayoub-segment, Any updates about this? Thanks. |
Hi @imsamdez , The deployment was completed last night. Can you try setting up a new Destination please? Feel free to schedule a call and I can take a look: http://calendly.com/joe_ayoub/integration-workshop Best regards, |
Also, i'm not sure why the PR seems to include previous jimo commits that has been already merged even if I synchronized my fork before doing my changes. Sorry about that, let me know if I can fix this.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.