Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channels-973: parse text field of action buttons #1738

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Channels-973: parse text field of action buttons #1738

merged 2 commits into from
Nov 29, 2023

Conversation

alfrimpong
Copy link
Contributor

@alfrimpong alfrimpong commented Nov 22, 2023 •
edited
Loading

Channels-973

This PR adds liquid trait parsing to the text field of action buttons

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@alfrimpong alfrimpong requested a review from a team as a code owner November 22, 2023 17:52
@alfrimpong alfrimpong requested a review from a team November 22, 2023 17:52
cogwizzle
cogwizzle approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@cogwizzle cogwizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joe-ayoub-segment joe-ayoub-segment self-assigned this Nov 23, 2023
@joe-ayoub-segment
Copy link
Contributor

hi @alfrimpong , I applied the 'Ready for Release' label to this PR, so it will be picked up when we do our next deploy (currently scheduled for next Wednesday.

If you don't want this PR deployed next Wednesday (for whatever reason) then please remove the label.

@joe-ayoub-segment joe-ayoub-segment merged commit 31e207c into main Nov 29, 2023
7 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the channels-973 branch November 29, 2023 11:44
Munter added a commit to bucketco/segment-action-destinations that referenced this pull request Nov 29, 2023
@Munter
Merge remote-tracking branch 'segment/main' into bucket-browser-desti…
92e1a93 
…nation

* segment/main: (59 commits)
  Publish
  attempting to fix breaking buildkite CI
  registering 1flow and jimo web Integrations
  Publish
  create trackEvent and identifyUser browser-destinations for 1flow (segmentio#1703)
  fix(Jimo): resolve when jimo is not an array & remove manualInit from settings (segmentio#1740)
  fix for empty string in setting (segmentio#1734)
  Yahoo audiences 5 (segmentio#1742)
  [STRATCONN] Klaviyo AddToProfileList and RemoveFromProfileList actions with engage setup (segmentio#1723)
  Add updateHandler to Actions DV360 (segmentio#1726)
  Inc-7055 long term fix: add external ids to message tags (segmentio#1744)
  Channels-973: parse text field of action buttons (segmentio#1738)
  LR: Fix CSV generator to account for all rows (segmentio#1735)
  [STRATCONN-3376] Add phone number to TikTok Audiences (segmentio#1730)
  rename full_name to display_name to fix API changes (segmentio#1743)
  adding default paths for click id and cookie (segmentio#1729)
  [Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call (segmentio#1733)
  adding updated generated types for moengage
  Added key value pair of new regional endpoint (segmentio#1727)
  v3.89.0 (segmentio#1725)
  ...
@joe-ayoub-segment
Copy link
Contributor

Hi @alfrimpong this PR has been deployed

harsh-joshi99 added a commit that referenced this pull request Dec 6, 2023
@harsh-joshi99
Squashed commit of the following:
975661d 
commit 12d62f7
Author: Harsh Joshi <[email protected]>
Date:   Wed Dec 6 10:29:30 2023 +0530

    cleanup

commit 3b8b9ed
Author: Harsh Joshi <[email protected]>
Date:   Mon Dec 4 10:36:54 2023 +0530

    Code changes and unit tests

commit 2edb75e
Merge: 8e9e776 ad48899
Author: Harsh Joshi <[email protected]>
Date:   Wed Nov 29 18:01:45 2023 +0530

    Merge branch 'STRATCONN-3399' into klaviyo-add-to-profile-batch

commit 8e9e776
Author: Elena <[email protected]>
Date:   Wed Nov 29 04:02:37 2023 -0800

    Yahoo audiences 5 (#1742)

    * new audience settings, logging

    * mapping change, device type

commit 7b0fe44
Author: Ankit Gupta <[email protected]>
Date:   Wed Nov 29 17:25:49 2023 +0530

    [STRATCONN] Klaviyo AddToProfileList and RemoveFromProfileList actions with engage setup (#1723)

    * AddToProfileList and RemoveFromProfileList action added

    * added new flow of addProfileToList and RemoveProfileFromList actions in klaviyo

    * completed audience setup for klaviyo

    * updated api key field for klaviyo

    * change in remove from list api test cases

    * full audience sync turned off for audience klaviyo

    * changing default path of external_id

    * Removed debug codes

    * code refactored

    * change in addProfile and removeProfile in klaviyo

    * Resolved build error

    * Resolved build error

    * Added buildHeaders function

    * Seperated addProfile and RemoveProfile Functions

    * Added audience desctiption

    * Change error handling of createProfile function

    * Change error handling of createProfile function

    * Modified in addProfileToList Test case

commit 6db1308
Author: Marín Alcaraz <[email protected]>
Date:   Wed Nov 29 03:54:19 2023 -0800

    Add updateHandler to Actions DV360 (#1726)

    * Add updateHandler to Actions DV360

    * Fix tests

    * update yarn.lock

commit ac78bc7
Author: alfrimpong <[email protected]>
Date:   Wed Nov 29 05:50:15 2023 -0600

    Inc-7055 long term fix: add external ids to message tags (#1744)

    * feat: add external id type & value to message tags

    * feat: add test to enforce passthrough

commit 31e207c
Author: alfrimpong <[email protected]>
Date:   Wed Nov 29 05:44:38 2023 -0600

    Channels-973: parse text field of action buttons (#1738)

    * feat: parse merge tags in action button text

    * chore: added unit test

commit 593b024
Author: Sayan Das <[email protected]>
Date:   Wed Nov 29 17:14:02 2023 +0530

    LR: Fix CSV generator to account for all rows (#1735)

    * Fixed CSV generator to account for all rows

    * Updated CSV processor, tests and snapshots

commit ce3c082
Author: maryamsharif <[email protected]>
Date:   Wed Nov 29 03:43:21 2023 -0800

    [STRATCONN-3376] Add phone number to TikTok Audiences (#1730)

    * Add phone number

    * Fix unit tests

    * Hide enable batching field + adjust names

commit 6fc66be
Author: Chris Brown <[email protected]>
Date:   Wed Nov 29 06:42:32 2023 -0500

    rename full_name to display_name to fix API changes (#1743)

    * rename full_name to display_name to fix API changes

    * Update full_name to display_name in tests

commit 10cc239
Author: Joe Ayoub <[email protected]>
Date:   Wed Nov 29 12:42:06 2023 +0100

    adding default paths for click id and cookie (#1729)

commit 5d80f5e
Author: zhadier39 <[email protected]>
Date:   Wed Nov 29 16:41:16 2023 +0500

    [Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call (#1733)

    * Add unit and integration tests

    * Updated field descriptions for group, identify and track

    * Updated common fields

    * Fix identify function error

    * Added authentication endpoint

    * Revise tests to enable auth

    * Update default paths for groupId.

    * Implement recommended changes from PR #1621

    * Add url field

    * Resolve pathing issues and add tests/checks for first and last name fields

    * Resolve test issues, payload validation error, and correct context default

    * Fix no user_id field in group call and timezone offset bug

    * Add tests for new functionality

    * Delete packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSFTP.types.ts

    Remove auto generated types file on liveramp platform

    * Fix ts error with timeZoneName

    ---------

    Co-authored-by: saadhypng <[email protected]>
    Co-authored-by: Saad Ali <[email protected]>

commit ad48899
Author: Harsh Joshi <[email protected]>
Date:   Wed Nov 29 15:54:05 2023 +0530

    Update error handling

commit e9f2370
Author: Harsh Joshi <[email protected]>
Date:   Fri Nov 24 11:42:37 2023 +0530

    Add enable batching

commit a75cedd
Author: Harsh Joshi <[email protected]>
Date:   Fri Nov 24 11:06:45 2023 +0530

    Add performBatch in upsert profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpdiaz8 miguelpdiaz8 miguelpdiaz8 approved these changes

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment approved these changes

@cogwizzle cogwizzle cogwizzle approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels
not-partner-eng-review (cloud) Ready for Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfrimpong @joe-ayoub-segment @cogwizzle @miguelpdiaz8