Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create trackEvent and identifyUser browser-destinations for 1flow #1703

Merged
merged 8 commits into from
Nov 29, 2023
Merged

create trackEvent and identifyUser browser-destinations for 1flow #1703

merged 8 commits into from
Nov 29, 2023

Conversation

namit1Flow
Copy link
Contributor

@namit1Flow namit1Flow commented Nov 1, 2023 •
edited
Loading

1Flow web

  • In this repo we are targeting trackEvent and identifyUser.
  • Initialize 1Flow and fire trackEvent(track) and idenfiyUser(identifyUser)

@namit1Flow namit1Flow requested review from a team as code owners November 1, 2023 07:08
@namit1Flow namit1Flow requested a review from a team November 1, 2023 07:08
@namit1Flow namit1Flow closed this Nov 1, 2023
@namit1Flow namit1Flow reopened this Nov 1, 2023
@namit1Flow namit1Flow closed this Nov 1, 2023
@namit1Flow namit1Flow reopened this Nov 1, 2023
@joe-ayoub-segment joe-ayoub-segment self-assigned this Nov 1, 2023
@joe-ayoub-segment
Copy link
Contributor

hi @namit1Flow - thanks for raising this PR.

As this is for a new Integration would you be available to meet with me to help me understand the use-cases for the Integration, as well as the types of data you want to send to the 1Flow platform?

You can schedule a call with me here: http://calendly.com/joe_ayoub/integration-workshop

I look forward to hearing from you!

Best regards,
Joe

@namit1Flow
Copy link
Contributor Author

Hi Joe,

We have a meeting today at 10:00 PM IST to discuss the integration.

@joe-ayoub-segment
Copy link
Contributor

Hi Namit,

Thanks for taking the time to catch up.
Please see the diff file for recommended changes, and please add unit tests.

Kind regards,
Joe

@joe-ayoub-segment
Copy link
Contributor

Hi @namit1Flow , just following up on this PR since our meeting on 8-Nov. Are you still interested in getting this PR live?
Are you clear on the changes we discussing during the call (which were shared via the diff file)?

Best regards,
Joe

@namit1Flow
Copy link
Contributor Author

namit1Flow commented Nov 17, 2023 •
edited
Loading

Hi, @joe-ayoub-segment suggested issues are fixed. Please check.

joe-ayoub-segment
joe-ayoub-segment requested changes Nov 22, 2023
View reviewed changes
packages/browser-destinations/destinations/1flow/src/index.ts Outdated
name: '1Flow',
slug: 'actions-1flow',
mode: 'device',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add description here:

description: 'Send user analytics events and user profile data from Segment to 1Flow',

@joe-ayoub-segment
Copy link
Contributor

Hi @namit1Flow - looks like the tests are failing. Can you take a look please?

image

@namit1Flow
Copy link
Contributor Author

Hi @namit1Flow - looks like the tests are failing. Can you take a look please?

image

Yeah, On it.

@namit1Flow
Copy link
Contributor Author

Hi @joe-ayoub-segment ,

Please check my latest commit and let me know if any action is needed.

@joe-ayoub-segment joe-ayoub-segment merged commit 3f950f9 into segmentio:main Nov 29, 2023
6 of 7 checks passed
Munter added a commit to bucketco/segment-action-destinations that referenced this pull request Nov 29, 2023
@Munter
Merge remote-tracking branch 'segment/main' into bucket-browser-desti…
92e1a93 
…nation

* segment/main: (59 commits)
  Publish
  attempting to fix breaking buildkite CI
  registering 1flow and jimo web Integrations
  Publish
  create trackEvent and identifyUser browser-destinations for 1flow (segmentio#1703)
  fix(Jimo): resolve when jimo is not an array & remove manualInit from settings (segmentio#1740)
  fix for empty string in setting (segmentio#1734)
  Yahoo audiences 5 (segmentio#1742)
  [STRATCONN] Klaviyo AddToProfileList and RemoveFromProfileList actions with engage setup (segmentio#1723)
  Add updateHandler to Actions DV360 (segmentio#1726)
  Inc-7055 long term fix: add external ids to message tags (segmentio#1744)
  Channels-973: parse text field of action buttons (segmentio#1738)
  LR: Fix CSV generator to account for all rows (segmentio#1735)
  [STRATCONN-3376] Add phone number to TikTok Audiences (segmentio#1730)
  rename full_name to display_name to fix API changes (segmentio#1743)
  adding default paths for click id and cookie (segmentio#1729)
  [Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call (segmentio#1733)
  adding updated generated types for moengage
  Added key value pair of new regional endpoint (segmentio#1727)
  v3.89.0 (segmentio#1725)
  ...
marinhero pushed a commit that referenced this pull request Nov 30, 2023
@namit1Flow @marinhero
create trackEvent and identifyUser browser-destinations for 1flow (#1703
69860c2 
)

* create trackEvent and identifyUser browser-destinations for 1flow

* track and identify fixes

* 1flow web fixes

* generated-types fixes

* Added Description For Destination

* Added Destination Description

* test issues fixes

* lint and jest issues fixes
@joe-ayoub-segment
Copy link
Contributor

Hi @namit1Flow ,

Apologies for the late notice, but we had to roll back this week's Web deploy due to an issue with some code which resulted in an incident.

It was unrelated to this PR, however we needed to roll back everything. We plan to deploy the code again across Monday/Tuesday next week.

Apologies again for the inconvenience.
Joe

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Dec 6, 2023 •
edited
Loading

hi @namit1Flow - this PR has been deployed.

I'll share next steps and instructions with you over email.

Kind regards,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels
partner-eng-review (device)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namit1Flow @joe-ayoub-segment