-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call #1733
Merged
Merged
[Hyperengage] Resolved issue with Timezone Offset and Added Missing user_id field in group call #1733
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
904ee55
Add unit and integration tests
zhadier39 521d658
Updated field descriptions for group, identify and track
saadhypng ab47298
Updated common fields
saadhypng f4832e4
Fix identify function error
zhadier39 6de967a
Added authentication endpoint
saadhypng ed36ea3
Merge pull request #1 from Hyperengage/feature/he-action-destination
saadhypng bb11b28
Revise tests to enable auth
zhadier39 a2f9483
Merge latest upstream changes
zhadier39 729c263
Update default paths for groupId.
zhadier39 557e01d
Implement recommended changes from PR #1621
zhadier39 e65c38d
Add url field
zhadier39 0b833d4
Resolve pathing issues and add tests/checks for first and last name f…
zhadier39 1c13eef
Resolve test issues, payload validation error, and correct context de…
zhadier39 9d28f9d
Merge branch 'main' of https://github.com/segmentio/action-destinations
zhadier39 b76a78c
Fix no user_id field in group call and timezone offset bug
zhadier39 a7fd188
Add tests for new functionality
zhadier39 fdde21d
Delete packages/destination-actions/src/destinations/liveramp-audienc…
zhadier39 90f7e36
Fix ts error with timeZoneName
zhadier39 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/destination-actions/src/destinations/hyperengage/group/generated-types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
packages/destination-actions/src/destinations/hyperengage/track/generated-types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
...ages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSFTP.types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Generated file. DO NOT MODIFY IT BY HAND. | ||
|
||
export interface Payload { | ||
/** | ||
* User credentials for establishing an SFTP connection with LiveRamp. | ||
*/ | ||
sftp_username?: string | ||
/** | ||
* User credentials for establishing an SFTP connection with LiveRamp. | ||
*/ | ||
sftp_password?: string | ||
/** | ||
* Path within the LiveRamp SFTP server to upload the files to. This path must exist and all subfolders must be pre-created. | ||
*/ | ||
sftp_folder_path?: string | ||
/** | ||
* Unique ID that identifies members of an audience. A typical audience key might be client customer IDs, email addresses, or phone numbers. | ||
*/ | ||
audience_key: string | ||
/** | ||
* Additional data pertaining to the user to be written to the file. | ||
*/ | ||
identifier_data?: { | ||
[k: string]: unknown | ||
} | ||
/** | ||
* Additional data pertaining to the user to be hashed before written to the file. Use field name **phone_number** or **email** to apply LiveRamp's specific hashing rules. | ||
*/ | ||
unhashed_identifier_data?: { | ||
[k: string]: unknown | ||
} | ||
/** | ||
* Character used to separate tokens in the resulting file. | ||
*/ | ||
delimiter: string | ||
/** | ||
* Name of the CSV file to upload for LiveRamp ingestion. | ||
*/ | ||
filename: string | ||
/** | ||
* Receive events in a batch payload. This is required for LiveRamp audiences ingestion. | ||
*/ | ||
enable_batching: boolean | ||
/** | ||
* Maximum number of events to include in each batch. Actual batch sizes may be lower. | ||
*/ | ||
batch_size?: number | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhadier39 and @saadhypng the PR looks good. Can you just remove the change to this file from the PR please?
It was likely automatically added when you ran the
./bin/run generate:types
command.Next steps are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhadier39 Will get this updated.
Also @joe-ayoub-segment On the deployment we will convert to our customers to install on next Thursday.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhadier39 and @saadhypng .
Just to clarify: We don't have a deploy happening this week. If we did we would push this change out.
The next deploy is next Wednesday/Thursday.
Best regards,
Joe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes got it, next Thursday it will be live. 30th November.