Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Diagnostic Reports #499

Merged
merged 21 commits into from
Nov 27, 2023
Merged

New Diagnostic Reports #499

merged 21 commits into from
Nov 27, 2023

Conversation

R-Palazzo
Copy link
Contributor

@R-Palazzo R-Palazzo commented Nov 7, 2023

CU-86ayjkc1e

Resolve #460
Resolve #461
Resolve #462
Resolve #463
Resolve #464
Resolve #467
Resolve #468
Resolve #469
Resolve #471
Resolve #494
Resolve #501
Resolve #502
Resolve #503
Resolve #504
Resolve #505
Resolve #506
Resolve #507
Resolve #508
Resolve #509
Resolve #510
Resolve #518
Resolve #526

@R-Palazzo R-Palazzo requested a review from a team as a code owner November 7, 2023 15:36
@R-Palazzo R-Palazzo removed the request for review from a team November 7, 2023 15:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (87790f2) 77.12% compared to head (9e83c54) 78.40%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ics/reports/multi_table/base_multi_table_report.py 83.33% 4 Missing ⚠️
...rics/reports/single_table/_properties/structure.py 81.81% 4 Missing ⚠️
.../reports/single_table/_properties/data_validity.py 95.45% 2 Missing ⚠️
sdmetrics/reports/multi_table/_properties/base.py 83.33% 1 Missing ⚠️
sdmetrics/reports/multi_table/diagnostic_report.py 66.66% 1 Missing ⚠️
...dmetrics/reports/single_table/diagnostic_report.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   77.12%   78.40%   +1.27%     
==========================================
  Files          93      102       +9     
  Lines        3488     3713     +225     
==========================================
+ Hits         2690     2911     +221     
- Misses        798      802       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdv-team
Copy link
Collaborator

Task linked: CU-86ayjkc1e New Diagnostic Report

@R-Palazzo R-Palazzo force-pushed the diagnostic_report_updates branch 2 times, most recently from 90f00db to b233260 Compare November 14, 2023 15:52
R-Palazzo and others added 20 commits November 27, 2023 08:50
@R-Palazzo R-Palazzo merged commit 004fbbe into main Nov 27, 2023
45 checks passed
@R-Palazzo R-Palazzo deleted the diagnostic_report_updates branch November 27, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants