Running single table report on multi table data (or vice versa) results in confusing error #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frances-h
reviewed
Nov 16, 2023
|
|
||
| error_message = ( | ||
| f'Multi table report {self.__class__.__name__} expects real and synthetic data to be' | ||
| ' dictionnaries of pandas.DataFrame. If your real and synthetic data are pd.DataFrame,' |
There was a problem hiding this comment.
typo: dictionnaries -> dictionaries
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## issue-507-validate-private #522 +/- ##
===========================================================
Coverage 78.38% 78.39%
===========================================================
Files 102 102
Lines 3697 3716 +19
===========================================================
+ Hits 2898 2913 +15
- Misses 799 803 +4 ☔ View full report in Codecov by Sentry. |
frances-h
approved these changes
Nov 17, 2023
Base automatically changed from
issue-507-validate-private
to
diagnostic_report_updates
November 17, 2023 15:54
R-Palazzo
force-pushed
the
issue-510-single-multi-report-error
branch
from
896773e
to
4caa4a0
Compare
R-Palazzo
added a commit
that referenced
this pull request
Nov 27, 2023
…ts in confusing error (#522)
R-Palazzo
added a commit
that referenced
this pull request
Nov 27, 2023
…ts in confusing error (#522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayp62w5
Resolve #510