Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyUniqueness metric should only be applied to primary and alternate keys #503

Closed
frances-h opened this issue Nov 9, 2023 · 0 comments · Fixed by #499
Closed

KeyUniqueness metric should only be applied to primary and alternate keys #503

frances-h opened this issue Nov 9, 2023 · 0 comments · Fixed by #499
Assignees
Labels
bug Something isn't working
Milestone

Comments

@frances-h
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDMetrics version: diagnostic_report_updates
  • Python version:
  • Operating System:

Error Description

In the DataValidity property, the KeyUniqueness metric is currently being applied to foreign key columns. The KeyUniqueness metric should only be applied to primary keys and alternate keys.

Steps to reproduce

from sdmetrics.demos import load_demo
from sdmetrics.reports.multi_table import DiagnosticReport

real_data, synthetic_data, metadata = load_demo(modality='multi_table')
report = DiagnosticReport()

report.generate(real_data, synthetic_data, metadata)
report.get_details('Data Validity')
@frances-h frances-h added bug Something isn't working new Label applied to new issues labels Nov 9, 2023
@npatki npatki removed the new Label applied to new issues label Nov 13, 2023
@amontanez24 amontanez24 added this to the 0.13.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants