Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single table Structure property should not have visualization #504

Closed
frances-h opened this issue Nov 9, 2023 · 0 comments · Fixed by #499
Closed

Single table Structure property should not have visualization #504

frances-h opened this issue Nov 9, 2023 · 0 comments · Fixed by #499
Assignees
Labels
bug Something isn't working
Milestone

Comments

@frances-h
Copy link
Contributor

frances-h commented Nov 9, 2023

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDMetrics version: diagnostic_report_updates
  • Python version:
  • Operating System:

Error Description

Currently get_visualization for the single table Structure property returns a bar graph with a single bar. Instead, it should error saying there is no available visualization for this property:

VisualizationUnavailableError: The single table Structure property does not have a supported visualization.

Steps to reproduce

from sdmetrics.demos import load_demo
from sdmetrics.reports.single_table import DiagnosticReport

real_data, synthetic_data, metadata = load_demo(modality='single_table')

report = DiagnosticReport()
report.generate(data, synthetic_data, metadata.to_dict())

report.get_visualization('Data Structure')
@frances-h frances-h added bug Something isn't working new Label applied to new issues labels Nov 9, 2023
@npatki npatki removed the new Label applied to new issues label Nov 13, 2023
@amontanez24 amontanez24 added this to the 0.13.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants