Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report validate method should be private #507

Closed
frances-h opened this issue Nov 9, 2023 · 0 comments · Fixed by #499
Closed

Report validate method should be private #507

frances-h opened this issue Nov 9, 2023 · 0 comments · Fixed by #499
Assignees
@R-Palazzo
Labels
bug Something isn't working
Milestone
0.13.0

Comments

@frances-h
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDMetrics version:
  • Python version:
  • Operating System:

Error Description

Currently, the validate method on BaseReport is a public method. This should be changed to a private method (_validate) as it is not part of the public API.

Steps to reproduce

from sdmetrics.reports.single_tableimport QualityReport

report = QualityReport()
report.validate(real_data, synthetic_data, metadata)
@frances-h frances-h added bug Something isn't working new Label applied to new issues labels Nov 9, 2023
@npatki npatki removed the new Label applied to new issues label Nov 13, 2023
This was referenced Nov 16, 2023
Merged
Merged
@amontanez24 amontanez24 added this to the 0.13.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-Palazzo R-Palazzo

Labels
bug Something isn't working
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

New Diagnostic Reports sdv-dev/SDMetrics
4 participants
@npatki @amontanez24 @frances-h @R-Palazzo