Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding base footprint publisher to nav2_util #3860

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

SteveMacenski
Copy link
Member

Required ros2/geometry2#632

Adds a nav2_util to take the base_link and automatically publish base_footprint synchronized with it that has Z, Pitch, and Roll removed so that users can have 3D state estimation but have a 2D footprint to use in navigation, visualization, or other needs in SE2 space.

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2023

@SteveMacenski, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@ros-navigation ros-navigation deleted a comment from mergify bot Oct 5, 2023
@SteveMacenski SteveMacenski marked this pull request as ready for review October 16, 2023 18:47
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (edfe5bf) 90.28% compared to head (b26be34) 90.26%.
Report is 1 commits behind head on main.

Files Patch % Lines
nav2_util/src/base_footprint_publisher.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
- Coverage   90.28%   90.26%   -0.03%     
==========================================
  Files         415      417       +2     
  Lines       18471    18510      +39     
==========================================
+ Hits        16677    16708      +31     
- Misses       1794     1802       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveMacenski SteveMacenski merged commit cefce2c into main Nov 16, 2023
5 of 7 checks passed
@SteveMacenski SteveMacenski deleted the footprint_publisher branch November 16, 2023 20:38
ajtudela pushed a commit to grupo-avispa/navigation2 that referenced this pull request Nov 17, 2023
* adding base footprint publisher to nav2_util

* adding unit test
lowellausen pushed a commit to lowellausen/navigation2 that referenced this pull request Nov 21, 2023
doisyg pushed a commit to doisyg/navigation2 that referenced this pull request Nov 27, 2023
SteveMacenski added a commit that referenced this pull request Nov 30, 2023
SteveMacenski added a commit that referenced this pull request Nov 30, 2023
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Jan 3, 2024
* adding base footprint publisher to nav2_util

* adding unit test

Signed-off-by: gg <[email protected]>
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Jan 3, 2024
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
* adding base footprint publisher to nav2_util

* adding unit test

Signed-off-by: enricosutera <[email protected]>
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* adding base footprint publisher to nav2_util

* adding unit test
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* adding base footprint publisher to nav2_util

* adding unit test
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant