-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul metrics [feature branch] #3209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic doesn't work yet.
…diagnostics to Debug/Console.WriteLine
…e json metrics sent over the wire
…on matched keyword
…into ac/analytics-in-sg
…s still not properly working in the tests.
|
||
if (match?.Groups.Count > 1) | ||
{ | ||
id = match.Groups[1].Value; |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
Variable [match](1) may be null at this access as suggested by [this](2) null check.
|
||
if (match?.Groups.Count > 1) | ||
{ | ||
id = match.Groups[1].Value; |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
Variable [match](1) may be null at this access as suggested by [this](2) null check.
* main: [v11] 10. Annotate projects for nullability (#3243) Merge v11 into main (#3268) Prepare for vNext (#3271) Prepare for 10.21.0 (#3270) Upgrade to Core 13.6.0 (#3269) Corrected error on README.md [skip-ci] Create simple project with Avalonia (#3263) Add support for compensating writes (#3259) # Conflicts: # Realm/Realm.Weaver/ImportedReferences.cs # Realm/Realm.Weaver/RealmWeaver.cs
* main: (29 commits) Add platform-specific helpers package (#3323) Allow geobox to be constructed from 4 coordinates (#3341) Add support for geospatial queries (#3300) Update UWP certificate, add instructions on how to do it (#3338) Don't throw an exception when setting an embedded property to the same value (#3337) Automatically handle object -> embedded object migrations (#3322) Add a check for the thread in Realm.IsInTransaction (#3336) Update to latest Core (#3334) Fix a few typos Move the SG and weaver binaries to the Realm package (#3319) Update ci-actions to latest commit (#3318) Fix a couple of warnings (#3317) Prepare for vNext (#3316) Prepare for 11.0.0 (#3315) Add support for arm on Linux (#3267) Update changelog Add tests for Set.PropertyChanged notifications (#3309) Change testing targets to net7.0 (#3305) Adjust codeql config (#3311) Allow publishing unity package on prerelease workflow (#3310) ... # Conflicts: # Realm/Realm.UnityWeaver/UnityWeaver.cs # wrappers/realm-core
nirinchev
added a commit
that referenced
this pull request
Jun 21, 2023
* main: (169 commits) Prepare for vNext (#3361) Prepare for 11.1.2 (#3360) Fix maui namespaces (#3357) Add a task to verify namespaces (#3358) Prepare for vNext (#3356) Prepare for 11.1.1 (#3355) Fix namespaces to ensure we don't have Realm as a namespace (#3353) Better warning for skipped properties with attributes (#3354) Revert "Better warning for skipped properties with attributes" Better warning for skipped properties with attributes Add nuget readme (#3350) Prepare for vNext (#3349) Prepare for 11.1.0 (#3348) Remove SG package reference from XUnit tests Use a different MSVC version (#3347) Overhaul metrics [feature branch] (#3209) Bump NuGet.Protocol from 5.9.3 to 6.0.5 (#3346) Add platform-specific helpers package (#3323) Allow geobox to be constructed from 4 coordinates (#3341) Add support for geospatial queries (#3300) ... # Conflicts: # .github/templates/main.yml # .github/templates/pr.yml # .github/templates/test-net-core.yml # .github/templates/test-uwp-managed.yml # .github/workflows/pr.yml # .github/workflows/test-uwp-managed.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the feature branch where every PR relative to overhaul metrics is going to be merged.
The content of this branch is, of course, already been reviewed and ready to be merged in master at any time.
Fixes #
TODO