Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create simple project with Avalonia #3263

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Create simple project with Avalonia #3263

merged 5 commits into from
Mar 21, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Mar 15, 2023

This PR adds an example project that uses Realm and Avalonia.

Differently from the example that we already have this application is mainly targeting desktop platforms, that is why the main view is a split view, with the todo lists collection on the left, and the current opened todo list on the right. For now I've tried it only on MacOS, and it looks good on it.

TODO

  • README.md

@papafe papafe requested a review from nirinchev March 15, 2023 14:12
@cla-bot cla-bot bot added the cla: yes label Mar 15, 2023
@papafe papafe added the no-changelog Used to skip the changelog check label Mar 15, 2023
@papafe
Copy link
Contributor Author

papafe commented Mar 15, 2023

@nirinchev It needs at least a README file, but I think most of the example project is there.
I've created this as a draft also to get feedback in case we want to do something differently.

Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I added a couple of very minor suggestions in #3266 that are up to you whether you want to incorporate or not.

examples/SimpleToDoAvalonia/SimpleToDo.csproj Show resolved Hide resolved
@papafe
Copy link
Contributor Author

papafe commented Mar 20, 2023

@nirinchev I've merged your changes (thanks!), added the readme file for the example, as well as updated the example part of the main readme file too.
Once we resolve the TrimmerRootAssembly discussion this is mergeable for me.

@papafe papafe merged commit 98a2b75 into main Mar 21, 2023
@papafe papafe deleted the fp/add-avalonia-example branch March 21, 2023 08:15
nirinchev added a commit that referenced this pull request Mar 24, 2023
* main:
  [v11] 10. Annotate projects for nullability (#3243)
  Merge v11 into main (#3268)
  Prepare for vNext (#3271)
  Prepare for 10.21.0 (#3270)
  Upgrade to Core 13.6.0 (#3269)
  Corrected error on README.md [skip-ci]
  Create simple project with Avalonia (#3263)
  Add support for compensating writes (#3259)

# Conflicts:
#	Realm/Realm.Weaver/ImportedReferences.cs
#	Realm/Realm.Weaver/RealmWeaver.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants