Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for compensating writes #3259

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Add support for compensating writes #3259

merged 6 commits into from
Mar 2, 2023

Conversation

nirinchev
Copy link
Member

Description

Fixes #3258

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Mar 2, 2023
@nirinchev nirinchev requested a review from fealebenpae March 2, 2023 02:38
@coveralls
Copy link

coveralls commented Mar 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4318276652

  • 39 of 40 (97.5%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 81.862%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Handles/SessionHandle.cs 15 16 93.75%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Extensions/TaskExtensions.cs 4 80.0%
Totals Coverage Status
Change from base Build 4294914153: -0.003%
Covered Lines: 5979
Relevant Lines: 7197
💛 - Coveralls

fealebenpae
fealebenpae requested changes Mar 2, 2023
View reviewed changes
Realm/Realm/Exceptions/CompensatingWriteException.cs Outdated Show resolved Hide resolved
Realm/Realm/Native/SyncError.cs Outdated Show resolved Hide resolved
wrappers/src/marshalling.hpp Outdated Show resolved Hide resolved
wrappers/src/marshalling.hpp Show resolved Hide resolved
@nirinchev nirinchev requested a review from fealebenpae March 2, 2023 17:29
fealebenpae
fealebenpae approved these changes Mar 2, 2023
View reviewed changes
Realm/Realm/Handles/SessionHandle.cs Outdated Show resolved Hide resolved
@nirinchev nirinchev merged commit 5c5c54a into main Mar 2, 2023
@nirinchev nirinchev deleted the ni/compensating-writes branch March 2, 2023 23:34
nirinchev added a commit that referenced this pull request Mar 24, 2023
@nirinchev
Merge branch 'main' into ac/overhaul-metrics
c699d38 
* main:
  [v11] 10. Annotate projects for nullability (#3243)
  Merge v11 into main (#3268)
  Prepare for vNext (#3271)
  Prepare for 10.21.0 (#3270)
  Upgrade to Core 13.6.0 (#3269)
  Corrected error on README.md [skip-ci]
  Create simple project with Avalonia (#3263)
  Add support for compensating writes (#3259)

# Conflicts:
#	Realm/Realm.Weaver/ImportedReferences.cs
#	Realm/Realm.Weaver/RealmWeaver.cs
@nirinchev nirinchev mentioned this pull request Apr 18, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compensating Writes
3 participants
@nirinchev @coveralls @fealebenpae