Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v11 into main #3268

Merged
merged 10 commits into from
Mar 24, 2023
Merged

Merge v11 into main #3268

merged 10 commits into from
Mar 24, 2023

Conversation

nirinchev
Copy link
Member

Description

Fixes #

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Mar 23, 2023
{
Argument.Ensure(primaryKey.HasValue, $"The class {className} has primary key defined, but you didn't pass one.", nameof(primaryKey));

objectHandle = _realm.SharedRealmHandle.CreateObjectWithPrimaryKey(pkProperty.Value, primaryKey.Value, metadata.TableKey, className, update: false, isNew: out var _);

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [primaryKey](1) may be null at this access because of [this](2) null argument. Variable [primaryKey](1) may be null at this access because it has a nullable type.

return _defaultConfiguration;
}
get => _defaultConfiguration ??= new RealmConfiguration();

Check notice

Code scanning / CodeQL

Static field written by instance method

Write to static field from instance method or constructor.
@nirinchev nirinchev marked this pull request as ready for review March 24, 2023 05:34
@nirinchev nirinchev merged commit d7b5e51 into main Mar 24, 2023
@nirinchev nirinchev deleted the main-v11 branch March 24, 2023 05:34
nirinchev added a commit that referenced this pull request Mar 24, 2023
* main:
  [v11] 10. Annotate projects for nullability (#3243)
  Merge v11 into main (#3268)
  Prepare for vNext (#3271)
  Prepare for 10.21.0 (#3270)
  Upgrade to Core 13.6.0 (#3269)
  Corrected error on README.md [skip-ci]
  Create simple project with Avalonia (#3263)
  Add support for compensating writes (#3259)

# Conflicts:
#	Realm/Realm.Weaver/ImportedReferences.cs
#	Realm/Realm.Weaver/RealmWeaver.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant