-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v11 into main #3268
Merged
Merge v11 into main #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | ||
Argument.Ensure(primaryKey.HasValue, $"The class {className} has primary key defined, but you didn't pass one.", nameof(primaryKey)); | ||
|
||
objectHandle = _realm.SharedRealmHandle.CreateObjectWithPrimaryKey(pkProperty.Value, primaryKey.Value, metadata.TableKey, className, update: false, isNew: out var _); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
Variable [primaryKey](1) may be null at this access because of [this](2) null argument.
Variable [primaryKey](1) may be null at this access because it has a nullable type.
|
||
return _defaultConfiguration; | ||
} | ||
get => _defaultConfiguration ??= new RealmConfiguration(); |
Check notice
Code scanning / CodeQL
Static field written by instance method
Write to static field from instance method or constructor.
nirinchev
added a commit
that referenced
this pull request
Mar 24, 2023
* main: [v11] 10. Annotate projects for nullability (#3243) Merge v11 into main (#3268) Prepare for vNext (#3271) Prepare for 10.21.0 (#3270) Upgrade to Core 13.6.0 (#3269) Corrected error on README.md [skip-ci] Create simple project with Avalonia (#3263) Add support for compensating writes (#3259) # Conflicts: # Realm/Realm.Weaver/ImportedReferences.cs # Realm/Realm.Weaver/RealmWeaver.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
TODO