Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Set.PropertyChanged notifications #3309

Merged
merged 1 commit into from
May 8, 2023

Conversation

nirinchev
Copy link
Member

Description

While looking at #3308, noticed we don't have explicit tests for it. While it doesn't seem like this was the problem reported there, figured it wouldn't hurt to have them just in case.

@cla-bot cla-bot bot added the cla: yes label May 8, 2023
@nirinchev nirinchev added no-changelog Used to skip the changelog check and removed cla: yes labels May 8, 2023
@nirinchev nirinchev marked this pull request as ready for review May 8, 2023 12:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4914966072

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 81.888%

Totals Coverage Status
Change from base Build 4896645773: 0.01%
Covered Lines: 5907
Relevant Lines: 7085

💛 - Coveralls

@nirinchev nirinchev merged commit 2212a17 into main May 8, 2023
@nirinchev nirinchev deleted the ni/set-property-changed branch May 8, 2023 13:01
nirinchev added a commit that referenced this pull request Jun 12, 2023
* main: (29 commits)
  Add platform-specific helpers package (#3323)
  Allow geobox to be constructed from 4 coordinates (#3341)
  Add support for geospatial queries (#3300)
  Update UWP certificate, add instructions on how to do it (#3338)
  Don't throw an exception when setting an embedded property to the same value (#3337)
  Automatically handle object -> embedded object migrations (#3322)
  Add a check for the thread in Realm.IsInTransaction (#3336)
  Update to latest Core (#3334)
  Fix a few typos
  Move the SG and weaver binaries to the Realm package (#3319)
  Update ci-actions to latest commit (#3318)
  Fix a couple of warnings (#3317)
  Prepare for vNext (#3316)
  Prepare for 11.0.0 (#3315)
  Add support for arm on Linux (#3267)
  Update changelog
  Add tests for Set.PropertyChanged notifications (#3309)
  Change testing targets to net7.0 (#3305)
  Adjust codeql config (#3311)
  Allow publishing unity package on prerelease workflow (#3310)
  ...

# Conflicts:
#	Realm/Realm.UnityWeaver/UnityWeaver.cs
#	wrappers/realm-core
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants