-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudf::column redesign #2207
Merged
kkraus14
merged 282 commits into
rapidsai:branch-0.10
from
jrhemstad:fea-ext-column-redesign
Oct 2, 2019
Merged
cudf::column redesign #2207
kkraus14
merged 282 commits into
rapidsai:branch-0.10
from
jrhemstad:fea-ext-column-redesign
Oct 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
added
libcudf
Affects libcudf (C++/CUDA) code.
2 - In Progress
Currently a work in progress
labels
Jul 9, 2019
rerun tests |
Test failure is innocuous, we have a 10 decimal point equality check for a rounding function in number and it was equal to 9 points, first time seeing that failure. Will admin merge this once the last gpu tester comes back and follow up on that test in an issue / PR to reduce the precision. |
9 tasks
This was referenced Oct 3, 2019
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
libcudf
Affects libcudf (C++/CUDA) code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1443
Depends on rapidsai/rmm#99
In effort to provide a replacement for
gdf_column
and related infrastructure, this PR introduces acudf::column
and associated classes.Goals:
Non Goals:
What's new?
cudf::column
column
types via a vector of "child"column
scudf::column_view
llvm::ArrayRef
can be constructed from acudf::column
or avoid*
to device memorycolumn
inputs to libcudf will be ascolumn_view
scudf::column_view
llvm::MutableArrayRef
, can be constructed from acudf::column
or avoid*
to device memorycolumn
in/out arguments to libcudf will be asmutable_column_view
scudf::column_device_view
__device__
accessorscudf::mutable_column_view
column_view
, for in/out parameters to libcudf functionscudf::exp::table
cudf::column
s of the same sizeexp
namespace to disambiguate from existingcudf::table
cudf::table_view
column_view
s of the same sizecudf::mutable_table_view
mutable_column_view
s of the same size