-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Port contents of functions.h to new cudf::column and associated types #2931
Comments
|
I started on this today |
Please follow the two-step approach (Start with a PR that only moves files to legacy and points include paths at them) |
Why are the gdf_nvtx_range_* functions declared in functions.h instead of nvtx_utils.h? These don't have anything to do with columns, but I could update them to CUDF_EXPECTS instead of returning gdf_error. |
First step here: #3070 |
Because all external APIs used to be defined in |
datetime_ops functions are covered by #3201 |
digitize is being deprecated by upper_bound and lower_bound: #3258 |
All PRs merged. Closing! |
Congrats and great work @trevorsm7, this was a tall order. |
Is your feature request related to a problem? Please describe.
Now that #2207 is merged we need to start porting functionality to use it. This issue covers functionality defined in
cudf/functions.h
.Describe the solution you'd like
Specifically:
gdf_order_by
(already implemented in cudf::column redesign #2207, so this is simply a header/namespace change)gdf_context_view
(not sure what to do with this -- need to look at usageAlso, functionality in functions.h largely uses the legacy "gdf" file structure and
gdf_valid_allocation_size
andgdf_num_bitmask_elements
won't be needed once the transition is complete, so for now they should just move to a header in the legacy folder and legacy namespace.nvtx
functions: useful to keep, should just be updated to throw exceptions and moved to their own header and in thecudf::utility
namespace or similar.gdf_error_get_name
etc.gdf_extract_datetime_second
and similar function may need to be handled in a separate refactor of date time functions.gdf_digitize
gdf_transpose
gdf_hash
gdf_hash_partition
gdf_to_dlpack
gdf_from_dlpack
Not all of the above needs to be done in a single PR. In fact, I recommend grouping it logically into multiple PRs to make reviewing and merging easy (and to enable collaboration).
The text was updated successfully, but these errors were encountered: