Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Modify Python digitize functions to use upper_bound and lower_bound #3258

Closed
trevorsm7 opened this issue Oct 31, 2019 · 3 comments
Closed
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@trevorsm7
Copy link
Contributor

Is your feature request related to a problem? Please describe.
gdf_digitize is being removed from the C++ API as it duplicates the functionality of cudf::upper_bound and cudf::lower_bound defined in #3229. There are Python bindings/wrapper around this function that need to be updated.

Describe the solution you'd like
The Python wrapper can call cudf::upper_bound and cudf::lower_bound instead.

@trevorsm7 trevorsm7 added feature request New feature or request Needs Triage Need team to review and classify Python Affects Python cuDF API. labels Oct 31, 2019
@kkraus14 kkraus14 removed the Needs Triage Need team to review and classify label Nov 13, 2019
@harrism
Copy link
Member

harrism commented Mar 12, 2020

@kkraus14 should this be covered by the Cython libcudf++ port?

@kkraus14
Copy link
Collaborator

No, likely will be done in a follow up.

@rgsl888prabhu
Copy link
Contributor

@kkraus14 @harrism #4191 has already incorporated lower_bound and upper_bound in digitize, I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Development

No branches or pull requests

4 participants