Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Porting sort.pyx to use new libcudf APIs #4191

Merged
merged 13 commits into from
Feb 20, 2020
Merged

[REVIEW] Porting sort.pyx to use new libcudf APIs #4191

merged 13 commits into from
Feb 20, 2020

Conversation

rgsl888prabhu
Copy link
Contributor

No description provided.

@rgsl888prabhu rgsl888prabhu added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Feb 19, 2020
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner February 19, 2020 01:11
@rgsl888prabhu rgsl888prabhu self-assigned this Feb 19, 2020
@rgsl888prabhu rgsl888prabhu changed the title [REVIEW] [REVIEW] Porting sort.pyx to use new libcudf APIs Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #4191 into branch-0.13 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13    #4191      +/-   ##
===============================================
+ Coverage        86.64%   86.65%   +<.01%     
===============================================
  Files               51       51              
  Lines             9863     9866       +3     
===============================================
+ Hits              8546     8549       +3     
  Misses            1317     1317
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 90% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191dcdd...12737cf. Read the comment docs.

kkraus14
kkraus14 requested changes Feb 19, 2020
View reviewed changes
python/cudf/cudf/_libxx/includes/sort.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/includes/sort.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/sort.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/sort.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/sort.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/sort.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_libxx/sort.pyx Show resolved Hide resolved
kkraus14
kkraus14 requested changes Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes, looks great!

python/cudf/cudf/core/_sort.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/_sort.py Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 19, 2020
@rgsl888prabhu
Copy link
Contributor Author

rerun tests

@kkraus14 kkraus14 merged commit 7e105dd into rapidsai:branch-0.13 Feb 20, 2020
@rgsl888prabhu rgsl888prabhu mentioned this pull request Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina Awaiting requested review from shwina

Assignees

@rgsl888prabhu rgsl888prabhu

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgsl888prabhu @kkraus14