-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Adding support for is_null and is_not_null #2962
[REVIEW] Adding support for is_null and is_not_null #2962
Conversation
Now that cudf::column (#2207) is merged, and since these operators should work the same on any kind of column (since they just operate on the null mask), it would be nice to implement these to operate on cudf::column since eventually gdf_column will be removed. Otherwise this is just adding technical debt. @rgsl888prabhu can you look into changing the APIs to use cudf::column? Edit: hmmm, this would depend on porting cudf::fill() first (#2936 ). So perhaps it should wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple PR. Can simplify it more with Thrust. Also some comment suggestions.
Branch 0.11
…l888prabhu/cudf into 2143_is_null_and_is_not_null
Codecov Report
@@ Coverage Diff @@
## branch-0.11 #2962 +/- ##
===============================================
+ Coverage 86.95% 87.02% +0.07%
===============================================
Files 49 49
Lines 9211 9194 -17
===============================================
- Hits 8009 8001 -8
+ Misses 1202 1193 -9
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgsl888prabhu this will be useful in the java side too (we work around this at the moment). One of us can put up a PR after this one is merged to use your new method. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor Python changes needed
Checks the input column for null values, and creates a bool column of same size with true representing null values and false for other - is_null
Checks the input column for null values, and creates a bool column of same size with false representing null values and true for other - is_not_null
close #2143