Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Port groupby to cudf::column types #2938

Closed
harrism opened this issue Oct 3, 2019 · 7 comments
Closed

[FEA] Port groupby to cudf::column types #2938

harrism opened this issue Oct 3, 2019 · 7 comments
Assignees
@devavret @jrhemstad
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@harrism
Copy link
Member

harrism commented Oct 3, 2019

Is your feature request related to a problem? Please describe.

Now that #2207 is merged we need to start porting functionality to use it. This issue covers functionality defined in cudf/groupby.hpp.

Describe the solution you'd like

Update the API functions definitions in cudf/groupby.hpp and their implementations to use the new cudf::column and associated classes.

Note that until string columns and other wrapper types are supported, operations will only be able to be implemented for numerical columns. Initially the "legacy" APIs should be kept in place but moved to the cudf/legacy folder and if necessary a legacy namespace.
@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels Oct 3, 2019
@harrism harrism added libcudf Affects libcudf (C++/CUDA) code. tech debt and removed Needs Triage Need team to review and classify labels Oct 3, 2019
@harrism harrism added the Spark Functionality that helps Spark RAPIDS label Oct 4, 2019
@ChuckHastings ChuckHastings mentioned this issue Oct 15, 2019
Merged
@ChuckHastings ChuckHastings mentioned this issue Oct 30, 2019
Closed
@harrism
Copy link
Member Author

harrism commented Nov 4, 2019

We will split this into two separate efforts: hash-based and sort-based. Assigning @jrhemstad to hash-based and @devavret to sort-based.

@harrism
Copy link
Member Author

harrism commented Jan 21, 2020

@jrhemstad @devavret can you update this issue with links to the PRs that close it?

@kkraus14
Copy link
Collaborator

Moving to 0.13 as hash groupby will not land for 0.12.

@devavret
Copy link
Contributor

Sort groupby merged in #3597.
Hash groupby PR not opened yet.

@devavret devavret mentioned this issue Jan 31, 2020
Merged
@harrism
Copy link
Member Author

harrism commented Mar 2, 2020

@devavret can you file issues for any remaining hash groupby features that are in progress? Then we can close this.

@harrism
Copy link
Member Author

harrism commented Mar 12, 2020

Ping @devavret. ⬆️

@devavret
Copy link
Contributor

Ping @devavret. ⬆️

Already did #4400 #4401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devavret devavret

@jrhemstad jrhemstad

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@harrism @devavret @kkraus14 @jrhemstad