Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudf::column redesign #2207
cudf::column redesign #2207
Changes from 161 commits
4f4ee73
846382a
1cdcacc
d38e2ae
49fcf9c
5bfcf62
8ccddd2
1f23cda
1f84167
3098923
ad5eea3
7b30632
d87f2cc
e44621f
955868f
a3427d5
2e6458f
ace7347
a1099fc
6c8bb12
8c5cb94
70d3d97
22e2de0
a04b732
fe4618e
548b7b6
e6e4335
b52094e
711ecf1
1756fe8
fc56e80
718f867
f19e15a
dd20a6a
f153007
3ded4fa
ee7ce4e
44c167d
e45f443
c454423
e56cd1c
782ffce
8406d49
85be5d0
9fab018
d504a29
97b62a9
247edca
109d633
6906bd1
7a3e966
ab19562
47ae45b
7fa51f5
0baf445
a71c73f
b0bcdd6
c3bafcd
8c715ac
17480f3
7d116a5
fcbdede
ebea3b0
ca4d065
04bca77
41f013e
7a8940b
7775d8a
37401cf
cbb87c6
ffb2726
3454786
46ac1a0
c1902b1
071d7c2
3e2bd6c
5c04740
f5cf8bf
acf8334
80ad711
512fff0
7a68b93
c0a2d8a
fda42bf
1c9863e
11404b8
de4f1ac
a2891d9
bbf6d21
286ab6b
ebea5bc
0b56e6f
939c911
4610629
f78890e
6eb5680
2cb3c57
f9f50aa
4aed0e5
1955a6f
e05378f
936a596
5fb3a74
14d87ea
ee3986c
490042e
2597557
52fe7ed
853e842
43cbabf
50b93e3
edf1b61
b75b4ef
c1b03f4
14bf61f
10ccfa0
04c8b4f
1567cb1
c880652
73f641c
956845b
9f26c69
ac5bc77
e8b541d
23bbb99
e3bce38
c2dca8f
892c21a
ae014da
c975add
fb4a9fc
94f24bf
5b32ea9
50ceb66
d03d703
6c71cb5
dda3f14
a8135a3
0fd3292
66d3f51
28d8d43
2596613
a43ae3e
55fba2b
6eaefb8
c79f234
3c1b96b
af668b8
c5c0c88
4b8a060
19f57fd
4178282
9acfb1f
af18d5f
630f00d
6a3a3d7
471373f
a82e26c
5bd7c1a
afc4989
80e70e9
28c2c4d
2762641
7371380
b1b1f3d
352eaab
6db8521
9a862c3
76655f5
b3ee825
09cdd5b
e3a1757
fc93c01
319db7e
5c1dbd9
f9a32a3
4100c48
4d9c018
9297df3
29f0ae2
10f09a8
dbde479
020d393
1e0a686
22ce2d9
521307f
46cb971
ccdf131
5cda050
e77ec2a
07b9459
2eee48f
19c797c
cca9a6c
88e5f52
1390e4a
551aed6
30d3e95
f3c3e0f
3627c1a
d627455
fcd6e83
3a05c85
67bb2d7
9525ccf
882d81d
6213ee3
e999142
227c256
2622a31
71f6833
a696f70
3e0385e
eff07cb
af4e4ea
842c5e2
5bf666c
87cb5c3
bb3f62f
7ff07ee
7e91014
9dfdb72
130af56
935d87b
b5f59c7
7e972e3
3d66f89
d24c6b7
f43405d
bfa99e6
e5c3f25
1bcd68d
501579c
fa46581
e7d690e
63dd7c9
ce39c3c
01f111a
1e6d8f8
bd1a419
cb8b505
b62921b
6f94ada
606c9db
ad6903b
e578176
e1d9088
745e792
7fb7979
f7fc79e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this and other column methods that launch kernels underneath, should they should use the stream specified in the constructor or an optional stream argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the fact that
null_count()
can potentially launch a kernel isn't something I want people to usually have to think about. That said, acolumn
doesn't have a stream member, it'sdevice_buffer
members do, and I think it would be odd to use those.So I guess it makes sense to add a defaulted stream parameter to this function, but it makes me feel a bit uncomfortable since
null_count()
is supposed to be masquerading as just a simpleconst
accessor.