Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin mimesis to <12 #14720

Closed
wants to merge 1 commit into from
Closed

Pin mimesis to <12 #14720

wants to merge 1 commit into from

Conversation

mroeschke
Copy link
Contributor

Description

Looks like a new mimesis version is failing with type annotation usage

https://github.com/rapidsai/cudf/actions/runs/7443972107/job/20262823436

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working non-breaking Non-breaking change labels Jan 8, 2024
@mroeschke mroeschke requested review from a team as code owners January 8, 2024 18:39
@github-actions github-actions bot added Python Affects Python cuDF API. conda labels Jan 8, 2024
bdice
bdice approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there is a past discussion of whether we could drop mimesis as a dependency here: #13257 (review)

We've run into breaking changes from mimesis several times before: #8745, #11906, #13257. I would really like to cut this dependency as it has been one of our most problematic dependencies, especially relative to how little we use it.

@bdice bdice mentioned this pull request Jan 8, 2024
Merged
3 tasks
@bdice
Copy link
Contributor

bdice commented Jan 8, 2024

Closing in favor of #14723. Thanks so much @mroeschke for the additional PR!

@bdice bdice closed this Jan 8, 2024
@mroeschke mroeschke deleted the deps/mimesis branch January 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @bdice @karthikeyann @ajschmidt8