Remove mimesis as a testing dependency #14723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks so much @mroeschke. I'm glad this wasn't too much work. Removing this dependency on mimesis will help a lot with preventing upstream breakage.
xref: #14720 (review)
ajschmidt8
approved these changes
Jan 8, 2024
shwina
approved these changes
Jan 8, 2024
|
/merge |
This was referenced Jan 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like this is used to generate random ages/cities/countries. As generically cudf should work with arbitrary ints/strings, I don't think it's critical that the test data has real world meaning
Checklist