-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll our own generate_string() because mimesis' has gone away #13257
Roll our own generate_string() because mimesis' has gone away #13257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwina Great news! I think this means we can drop the mimesis dependency entirely. Can you do that in this PR?
Note: We may also need to drop this pinning from the integration repository. |
@bdice it looks like there are some non-trivial uses for cudf/python/cudf/cudf/tests/test_parquet.py Line 464 in f27be56
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwina Thanks for noting the nontrivial uses of mimesis. I hadn't caught those when reading before because it isn't directly calling mimesis
, it's going through some kind of generator API.
However, I wonder if we could move towards cutting those features from our code... it doesn't seem particularly important to have a "city name generator" as a dependency in cudf.
/merge |
Starting
mimesis=9.0.0
, thegenerate_string
function has become private:This PR replaces all uses of the function with a homespun one. Note that the implementation is about as fast (perhaps identical?)