[REVIEW] Pin mimesis to <4.1
#8745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
tech debt
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8745 +/- ##
===============================================
Coverage ? 10.36%
===============================================
Files ? 109
Lines ? 19223
Branches ? 0
===============================================
Hits ? 1993
Misses ? 17230
Partials ? 0 Continue to review full report at Codecov.
|
|
rerun tests |
ajschmidt8
approved these changes
Jul 15, 2021
skirui-source
approved these changes
Jul 15, 2021
|
@gpucibot merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
The dependency pinning for `mimesis` in cudf's `setup.py` didn't match the conda environment. It was missing a pinning to `<4.1` from #8745. However, based on the conversation in #8551, this pinning of `<4.1` was only chosen because 4.1.0 wasn't yet available on conda-forge. Since the current version of mimesis is now 6.1.1, this PR updates the mimesis pinning to `>=4.1` and uses `generate_string` instead of `schoice`. I tested this locally with mimesis 6.1.1 and mimesis 4.1.0 and both passed tests. Merge this PR concurrently with rapidsai/integration#547. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - AJ Schmidt (https://github.com/ajschmidt8) URL: #11906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8551
This PR enables version pinning for
mimesis. The version constrained to is<4.1.