Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin mimesis version in setup.py. #11906

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Pin mimesis version in setup.py. #11906

merged 3 commits into from
Oct 18, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 11, 2022 •
edited
Loading

Description

The dependency pinning for mimesis in cudf's setup.py didn't match the conda environment. It was missing a pinning to <4.1 from #8745. However, based on the conversation in #8551, this pinning of <4.1 was only chosen because 4.1.0 wasn't yet available on conda-forge. Since the current version of mimesis is now 6.1.1, this PR updates the mimesis pinning to >=4.1 and uses generate_string instead of schoice. I tested this locally with mimesis 6.1.1 and mimesis 4.1.0 and both passed tests.

Merge this PR concurrently with rapidsai/integration#547.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 11, 2022
@bdice bdice mentioned this pull request Oct 11, 2022
Merged
@github-actions github-actions bot added the conda label Oct 11, 2022
@bdice bdice marked this pull request as ready for review October 11, 2022 21:59
@bdice bdice requested review from a team as code owners October 11, 2022 21:59
@bdice bdice requested review from vyasr and isVoid October 11, 2022 21:59
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 11, 2022
@bdice bdice self-assigned this Oct 11, 2022
@vyasr vyasr mentioned this pull request Oct 12, 2022
Closed
@vyasr
Copy link
Contributor

vyasr commented Oct 12, 2022

Opened rapidsai/integration#548 to unblock tests.

@galipremsagar
Copy link
Contributor

Opened rapidsai/integration#548 to unblock tests.

Looks like @bdice already opened a PR: rapidsai/integration#547

@vyasr
Copy link
Contributor

vyasr commented Oct 12, 2022

Didn't see that :) Closed mine.

@galipremsagar
Copy link
Contributor

rerun tests

2 similar comments
@bdice
Copy link
Contributor Author

bdice commented Oct 18, 2022

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 87.40% // Head: 88.13% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (170a12b) compared to base (f72c4ce).
Patch coverage: 88.48% of modified lines in pull request are covered.

❗ Current head 170a12b differs from pull request most recent head 8f717e7. Consider uploading reports for the commit 8f717e7 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12   #11906      +/-   ##
================================================
+ Coverage         87.40%   88.13%   +0.72%     
================================================
  Files               133      133              
  Lines             21833    21905      +72     
================================================
+ Hits              19084    19305     +221     
+ Misses             2749     2600     -149
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.96% <95.71%> (+0.33%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/_lib/strings/__init__.py 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ajschmidt8
ajschmidt8 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@galipremsagar
Copy link
Contributor

galipremsagar commented Oct 18, 2022 •
edited
Loading

@gpucibot merge

1 similar comment
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cea10ca into rapidsai:branch-22.12 Oct 18, 2022
@etseidl etseidl mentioned this pull request Oct 19, 2022
Merged
3 tasks
@bdice bdice mentioned this pull request Jan 8, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @vyasr @galipremsagar @ajschmidt8