Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Constrain mimesis to <4.1 in dev environments #8551

Closed
beckernick opened this issue Jun 18, 2021 · 0 comments · Fixed by #8745
Closed

[FEA] Constrain mimesis to <4.1 in dev environments #8551

beckernick opened this issue Jun 18, 2021 · 0 comments · Fixed by #8745
Assignees
@galipremsagar
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@beckernick
Copy link
Member

beckernick commented Jun 18, 2021 •
edited
Loading

As discovered in #8550 , mimesis 4.1.0 introduced a breaking change that can affect us, as we use Random.schoice in tests.

In conda-forge, mimesis is at version 4.0.0, so this has not presented previously. As noted by @shwina , we likely want to constrain to <4.1 for now and then update when 4.1+ becomes available on conda-forge.
@beckernick beckernick added feature request New feature or request Python Affects Python cuDF API. conda labels Jun 18, 2021
@galipremsagar galipremsagar self-assigned this Jun 18, 2021
@beckernick beckernick mentioned this issue Jun 18, 2021
Closed
@galipremsagar galipremsagar mentioned this issue Jul 14, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 15, 2021
@galipremsagar
Pin mimesis to <4.1 (#8745)
798c8d2 
Resolves: #8551 

This PR enables version pinning for `mimesis`. The version constrained to is `<4.1`.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Sheilah Kirui (https://github.com/skirui-source)

URL: #8745
@bdice bdice mentioned this issue Oct 11, 2022
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Oct 18, 2022
@bdice
Pin mimesis version in setup.py. (#11906)
cea10ca 
The dependency pinning for `mimesis` in cudf's `setup.py` didn't match the conda environment. It was missing a pinning to `<4.1` from #8745. However, based on the conversation in #8551, this pinning of `<4.1` was only chosen because 4.1.0 wasn't yet available on conda-forge. Since the current version of mimesis is now 6.1.1, this PR updates the mimesis pinning to `>=4.1` and uses `generate_string` instead of `schoice`. I tested this locally with mimesis 6.1.1 and mimesis 4.1.0 and both passed tests.

Merge this PR concurrently with rapidsai/integration#547.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #11906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Pin mimesis to <4.1 galipremsagar/cudf
2 participants
@beckernick @galipremsagar