Allow unicode characters for package routes #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
=======================================
Coverage 47.42% 47.42%
=======================================
Files 441 441
Lines 21138 21138
Branches 2436 2436
=======================================
Hits 10024 10024
Misses 10206 10206
Partials 908 908
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nl0
approved these changes
Apr 22, 2021
nl0
added a commit
that referenced
this pull request
Apr 23, 2021
* master: Allow unicode characters for package routes by allowing any character (#2179) Additional NotFoundPage scoped to Bucket (#2175) Docs: fix catalog config path (#2168) rework pkgpush auth (#2170) Use AWS credentials for directory package and copy package submit (#2172) Document package push limitations in catalog [ci skip] (#2161) Preview warnings accordion (#2167) tweak warning text (#2169) Copy tweaks (#2164) Don't crash pkgselect for empty manifests (#2147) add codecov config (#2155)
nl0
added a commit
that referenced
this pull request
May 4, 2021
* master: (54 commits) Use stable nginx version for catalog image (#2182) Ability to add S3 folders / files to package (#2171) lambda for adding S3 data to existing package (#2180) use github tarball for faster installation (#2181) Bump py from 1.7.0 to 1.10.0 in /lambdas/es/indexer (#2176) Bump py from 1.8.0 to 1.10.0 in /lambdas/s3select (#2177) Bump py from 1.8.0 to 1.10.0 in /lambdas/thumbnail (#2178) Allow unicode characters for package routes by allowing any character (#2179) Additional NotFoundPage scoped to Bucket (#2175) Docs: fix catalog config path (#2168) rework pkgpush auth (#2170) Use AWS credentials for directory package and copy package submit (#2172) Document package push limitations in catalog [ci skip] (#2161) Preview warnings accordion (#2167) tweak warning text (#2169) Copy tweaks (#2164) Don't crash pkgselect for empty manifests (#2147) add codecov config (#2155) Simplify warning messages for package name (#2134) Move package API requests to one file, consolidate naming and internal API (#2154) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python RegExp slightly different from Javascript. In Python's
\wUnicode is included, in JavaScript - ASCII only:There is a special characters sequence to match any Unicode symbol:
\p{L}, but to match Unicode symbols RegExp should be called with 'u' flag. "path-to-regexp" (library behind "react-router") doesn't use it: https://github.com/pillarjs/path-to-regexp/blob/79a5dcf5f2a79a99fbaaccae20cd922a745e0f83/index.js#L261As a workaround, I allowed any character. Results are: