Ability to add S3 folders / files to package

[nl0]

Description

TODO

• Unit tests
• Automated tests (e.g. Preflight)
• Documentation
  • Python: Run build.py for new docstrings
  • JavaScript: basic explanation and screenshot of new features
• Changelog entry

[codecov]

Codecov Report

Merging #2171 (b3732bf) into master (85edf0c) will decrease coverage by 1.40%.
The diff coverage is 4.09%.

@@            Coverage Diff             @@
##           master    #2171      +/-   ##
==========================================
- Coverage   47.96%   46.55%   -1.41%     
==========================================
  Files         441      443       +2     
  Lines       21357    22012     +655     
  Branches     2436     2654     +218     
==========================================
+ Hits        10244    10248       +4     
- Misses      10205    10854     +649     
- Partials      908      910       +2     

Flag	Coverage Δ
api-python	89.85% <ø> (ø)
catalog	15.51% <4.09%> (-0.79%)	⬇️
lambda	94.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
catalog/app/components/BreadCrumbs/BreadCrumbs.js	0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx	0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Listing.tsx	0.00% <0.00%> (ø)
...talog/app/containers/Bucket/PackageCreateDialog.js	0.00% <0.00%> (ø)
...app/containers/Bucket/PackageDialog/FilesInput.tsx	0.00% <0.00%> (ø)
...p/containers/Bucket/PackageDialog/S3FilePicker.tsx	0.00% <0.00%> (ø)
...alog/app/containers/Bucket/PackageUpdateDialog.tsx	0.00% <0.00%> (ø)
catalog/app/utils/AWS/S3.js	19.56% <0.00%> (-1.72%)	⬇️
...og/app/containers/Bucket/requests/bucketListing.ts	16.36% <17.14%> (+0.36%)	⬆️
catalog/app/containers/Bucket/requests/package.ts	34.32% <26.08%> (-2.18%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85edf0c...b3732bf. Read the comment docs.

[fiskus]

Please, ping me, when backend will be ready, so I can help you with testing

[fiskus]

Maybe, it's better to stick with one style rule for props types: type or interface. If we use interfaces, because they are superior then types, then we can use this:

export interface CellProps extends React.PropsWithChildren<{
  item: Item
  title?: string
  className?: string
}> {}

or

export interface CellProps extends React.PropsWithChildren<{}> {
  item: Item
  title?: string
  className?: string
}

[nl0]

well, they are not 100% superior, it's just a recommendation to use interfaces when possible, but it seems to me that interface A extends SomeType<...> {} doesnt make much sense, bc it's equivalent to just SomeType<...>.
interface A extends React.PropsWithChildren<{}> { ... } looks better, but still resembles some workaround and doesnt buy as much compared to when we specify children explicitly: interface A { children?: React.ReactNode, ... } (extends React.PropsWithChildren<{}> vs children?: React.ReactNode)

[nl0]

Please, ping me, when backend will be ready, so I can help you with testing

@fiskus it is now