Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional NotFoundPage scoped to Bucket #2175

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 19, 2021

Before
1 before

After
2 after

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #2175 (6e110a3) into master (c2529b2) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2175      +/-   ##
==========================================
- Coverage   47.46%   47.42%   -0.05%     
==========================================
  Files         440      441       +1     
  Lines       21124    21138      +14     
  Branches     2434     2436       +2     
==========================================
- Hits        10026    10024       -2     
- Misses      10190    10206      +16     
  Partials      908      908              
Flag Coverage Δ
api-python 89.85% <ø> (-0.04%) ⬇️
catalog 16.30% <0.00%> (-0.02%) ⬇️
lambda 93.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Bucket.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/CatchNotFound.tsx 0.00% <0.00%> (ø)
api/python/quilt3/search_util.py 75.86% <0.00%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2529b2...6e110a3. Read the comment docs.

@fiskus fiskus requested a review from nl0 April 19, 2021 12:09
@fiskus fiskus merged commit bb239ad into master Apr 19, 2021
@fiskus fiskus deleted the bucket-package-not-found branch April 19, 2021 14:06
nl0 added a commit that referenced this pull request Apr 23, 2021
* master:
  Allow unicode characters for package routes by allowing any character (#2179)
  Additional NotFoundPage scoped to Bucket (#2175)
  Docs: fix catalog config path (#2168)
  rework pkgpush auth (#2170)
  Use AWS credentials for directory package and copy package submit (#2172)
  Document package push limitations in catalog [ci skip] (#2161)
  Preview warnings accordion (#2167)
  tweak warning text (#2169)
  Copy tweaks (#2164)
  Don't crash pkgselect for empty manifests (#2147)
  add codecov config (#2155)
nl0 added a commit that referenced this pull request May 4, 2021
* master: (54 commits)
  Use stable nginx version for catalog image (#2182)
  Ability to add S3 folders / files to package (#2171)
  lambda for adding S3 data to existing package (#2180)
  use github tarball for faster installation (#2181)
  Bump py from 1.7.0 to 1.10.0 in /lambdas/es/indexer (#2176)
  Bump py from 1.8.0 to 1.10.0 in /lambdas/s3select (#2177)
  Bump py from 1.8.0 to 1.10.0 in /lambdas/thumbnail (#2178)
  Allow unicode characters for package routes by allowing any character (#2179)
  Additional NotFoundPage scoped to Bucket (#2175)
  Docs: fix catalog config path (#2168)
  rework pkgpush auth (#2170)
  Use AWS credentials for directory package and copy package submit (#2172)
  Document package push limitations in catalog [ci skip] (#2161)
  Preview warnings accordion (#2167)
  tweak warning text (#2169)
  Copy tweaks (#2164)
  Don't crash pkgselect for empty manifests (#2147)
  add codecov config (#2155)
  Simplify warning messages for package name (#2134)
  Move package API requests to one file, consolidate naming and internal API (#2154)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants