Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS credentials for directory package and copy package submit #2172

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 15, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2172 (c83ee6d) into master (d43a2ce) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2172      +/-   ##
==========================================
- Coverage   47.46%   47.45%   -0.02%     
==========================================
  Files         440      440              
  Lines       21115    21124       +9     
  Branches     2433     2434       +1     
==========================================
+ Hits        10022    10024       +2     
- Misses      10185    10192       +7     
  Partials      908      908              
Flag Coverage Δ
api-python 89.87% <ø> (ø)
catalog 16.32% <25.00%> (+<0.01%) ⬆️
lambda 93.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/requests/package.ts 36.50% <25.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43a2ce...c83ee6d. Read the comment docs.

@fiskus fiskus requested review from nl0 and sir-sigurd April 15, 2021 15:44
@sir-sigurd sir-sigurd requested a review from akarve April 15, 2021 16:00
Copy link
Member

@sir-sigurd sir-sigurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works.

@akarve akarve merged commit de6bfcb into master Apr 16, 2021
@akarve akarve deleted the credentials-copy-and-directory branch April 16, 2021 01:59
nl0 added a commit that referenced this pull request Apr 23, 2021
* master:
  Allow unicode characters for package routes by allowing any character (#2179)
  Additional NotFoundPage scoped to Bucket (#2175)
  Docs: fix catalog config path (#2168)
  rework pkgpush auth (#2170)
  Use AWS credentials for directory package and copy package submit (#2172)
  Document package push limitations in catalog [ci skip] (#2161)
  Preview warnings accordion (#2167)
  tweak warning text (#2169)
  Copy tweaks (#2164)
  Don't crash pkgselect for empty manifests (#2147)
  add codecov config (#2155)
nl0 added a commit that referenced this pull request May 4, 2021
* master: (54 commits)
  Use stable nginx version for catalog image (#2182)
  Ability to add S3 folders / files to package (#2171)
  lambda for adding S3 data to existing package (#2180)
  use github tarball for faster installation (#2181)
  Bump py from 1.7.0 to 1.10.0 in /lambdas/es/indexer (#2176)
  Bump py from 1.8.0 to 1.10.0 in /lambdas/s3select (#2177)
  Bump py from 1.8.0 to 1.10.0 in /lambdas/thumbnail (#2178)
  Allow unicode characters for package routes by allowing any character (#2179)
  Additional NotFoundPage scoped to Bucket (#2175)
  Docs: fix catalog config path (#2168)
  rework pkgpush auth (#2170)
  Use AWS credentials for directory package and copy package submit (#2172)
  Document package push limitations in catalog [ci skip] (#2161)
  Preview warnings accordion (#2167)
  tweak warning text (#2169)
  Copy tweaks (#2164)
  Don't crash pkgselect for empty manifests (#2147)
  add codecov config (#2155)
  Simplify warning messages for package name (#2134)
  Move package API requests to one file, consolidate naming and internal API (#2154)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants