Copy tweaks #2164
Merged
Copy tweaks #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
=======================================
Coverage 47.47% 47.47%
=======================================
Files 440 440
Lines 21109 21109
Branches 2432 2432
=======================================
Hits 10022 10022
Misses 10177 10177
Partials 910 910
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nl0
approved these changes
Apr 13, 2021
nl0
added a commit
that referenced
this pull request
Apr 23, 2021
* master: Allow unicode characters for package routes by allowing any character (#2179) Additional NotFoundPage scoped to Bucket (#2175) Docs: fix catalog config path (#2168) rework pkgpush auth (#2170) Use AWS credentials for directory package and copy package submit (#2172) Document package push limitations in catalog [ci skip] (#2161) Preview warnings accordion (#2167) tweak warning text (#2169) Copy tweaks (#2164) Don't crash pkgselect for empty manifests (#2147) add codecov config (#2155)
nl0
added a commit
that referenced
this pull request
May 4, 2021
* master: (54 commits) Use stable nginx version for catalog image (#2182) Ability to add S3 folders / files to package (#2171) lambda for adding S3 data to existing package (#2180) use github tarball for faster installation (#2181) Bump py from 1.7.0 to 1.10.0 in /lambdas/es/indexer (#2176) Bump py from 1.8.0 to 1.10.0 in /lambdas/s3select (#2177) Bump py from 1.8.0 to 1.10.0 in /lambdas/thumbnail (#2178) Allow unicode characters for package routes by allowing any character (#2179) Additional NotFoundPage scoped to Bucket (#2175) Docs: fix catalog config path (#2168) rework pkgpush auth (#2170) Use AWS credentials for directory package and copy package submit (#2172) Document package push limitations in catalog [ci skip] (#2161) Preview warnings accordion (#2167) tweak warning text (#2169) Copy tweaks (#2164) Don't crash pkgselect for empty manifests (#2147) add codecov config (#2155) Simplify warning messages for package name (#2134) Move package API requests to one file, consolidate naming and internal API (#2154) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nl0 in the A/B flavors do we send the copy itself so to the analytics beacon so that we can tease out conversion differences? Anything I need to do besides changing the strings?