-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode
#5547
Comments
yunhanw-google
changed the title
Replace aGeneralCode with
Replace aGeneralCode with Mar 22, 2021
chip::Protocols::SecureChannel::GeneralStatusCode
, no?chip::Protocols::SecureChannel::GeneralStatusCode
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this issue
Mar 31, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode fixed project-chip#5494 project-chip#5547
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this issue
Mar 31, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode fixed project-chip#5494 project-chip#5547
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this issue
Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. fixed project-chip#5494 project-chip#5547
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this issue
Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. -- Remove extra status code insertion in command sender since status code is only present for command handler. fixed project-chip#5494 project-chip#5547
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this issue
Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. -- Remove extra status code insertion in command sender since status code is only present for command handler. fixed project-chip#5494 project-chip#5547 project-chip#5756
msandstedt
pushed a commit
that referenced
this issue
Apr 2, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. -- Remove extra status code insertion in command sender since status code is only present for command handler. fixed #5494 #5547 #5756
jimlyall-q
pushed a commit
to jimlyall-q/connectedhomeip
that referenced
this issue
Apr 13, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. -- Remove extra status code insertion in command sender since status code is only present for command handler. fixed project-chip#5494 project-chip#5547 project-chip#5756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The type for aGeneralCode should probably be
chip::Protocols::SecureChannel::GeneralStatusCode
, no?Originally posted by @bzbarsky-apple in #5477 (comment)
The text was updated successfully, but these errors were encountered: