Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode #5547

Closed
yunhanw-google opened this issue Mar 22, 2021 · 0 comments
Assignees

Comments

@yunhanw-google
Copy link
Contributor

The type for aGeneralCode should probably be chip::Protocols::SecureChannel::GeneralStatusCode, no?

Originally posted by @bzbarsky-apple in #5477 (comment)

@yunhanw-google yunhanw-google changed the title Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode, no? Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode Mar 22, 2021
@yunhanw-google yunhanw-google self-assigned this Mar 22, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Mar 31, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Mar 31, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547 project-chip#5756
msandstedt pushed a commit that referenced this issue Apr 2, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed #5494 #5547 #5756
jimlyall-q pushed a commit to jimlyall-q/connectedhomeip that referenced this issue Apr 13, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547 project-chip#5756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant